2024-08-28 Nix team meeting minutes #173

Development Nix
1

Wednesday triaging meeting

Attendees: @roberth @tomberek @Ericson2314

Triage

remote build of 'silent' packages fails · Issue #4427 · NixOS/nix · GitHub

Idea approved

space out the output of "building ..." in `nixos-rebuild` · Issue #11310 · NixOS/nix · GitHub

  • Eelco has worked on a multi line progress bar implementation a long time ago; very stale
  • This is less invasive
  • Might clobber output to stderr that might currently not be

Assign to Eelco, tentatively

libexpr: make "or"-as-variable less bogus by rhendric · Pull Request #11121 · NixOS/nix · GitHub

How hard would a deprecation cycle be to implement?
Can we be confident that we emit warnings for all expressions whose behavior we’d like to change?

Maybe this can be expressed in the grammar by having more rules?

install-darwin: fix _nixbld uids for macOS sequoia by abathur · Pull Request #10919 · NixOS/nix · GitHub

  • Error message:

    • We could provide a better error. The problem is with the group memberships.
    • Could we recover from this situation with group memberships? We should be able to.

  • Installer

    • Should we auto migrate the user ids, or should it be a manual operation?
      • Maybe make it automatic over time?
      • Have a confirmation: we’re about to migrate. [y/n]?
        • or maybe that’s just annoying
    • What does it take to decide?
    • Maybe detect the situation very well, so we can be conservative about applying the migration, reducing the risk

  • Another approach may be to work around the issue and remove/ignore the first 4(?) that are actually a problem; just use the rest for now

    • backport this to previous releases
    • local-derivation-goal: try next user when it fails

  • DetSys installer is waiting for our decision

Warn on malformed URI query parameter by bryanhonof · Pull Request #11349 · NixOS/nix · GitHub

Merged.

completeFlakeRefWithFragment: handle names with dots by ylh · Pull Request #11377 · NixOS/nix · GitHub

Reviewed:
We think before we support this feature we should clean up the code a bit.

  • We should strive to have separate functions for quoting and unquoting (and ideally unit test that they round-trip). There might be something in libutil already to help with this (quoteStrings)

    • Maybe it needs to be a variation of what we have because of the potentially missing start/end quotes
    • Even if it’s a variation, centralizing it makes sure that we don’t duplicate code unnecessarily

  • Get rid of the goto with a refactor

3 Likes