Btw @lucasew has been working on introduce npv_169 to detect top level withs by lucasew · Pull Request #142 · NixOS/nixpkgs-vet · GitHub which would disallow introducing new instances of certain uses of with in Nixpkgs, but we still need a bit more consensus as to what the exact check should be. So this is a great thread for this 
4 Likes