Enforcing Nix formatting in Nixpkgs

[Infinisil]

@payas

On another note, does this mean we can finally rename nixfmt-rfc-style back to nixfmt?

I’d say let’s wait a bit longer with that, but yeah that’s the plan eventually

@payas

I also remember some mention of integrating the chosen formatter within Nix itself, so as to not need a separate tool apart from nix format. Is that still the plan?

It’s in the RFC 166 implementation tracking issue, so yeah. I likely won’t get to that anytime soon, but anybody else is free to do that, just synchronise with the formatting team

@nicolas-goudry

Also, I noticed in the nixfmt repository that it states the following:

The official (but not yet stable) formatter for Nix code

Should it still be considered unstable? Should we expect a v1 release soon (last one is from October 2023)?

There’s still at least Maintain expanded attrs/lists/attr params/inherits by infinisil · Pull Request #224 · NixOS/nixfmt · GitHub to merge, perhaps also /* comments */ should not be reformatted · Issue #179 · NixOS/nixfmt · GitHub before we go ahead with the treewide reformat. But after that I think we can do a 1.0 release and call it stable (which notably wouldn’t mean that the formatting can’t change anymore!).