Sorry for interrupting the meaningful conversation, but I would just like to mention that I talked to @Sandro, and we agreed on a few things to make his reviews a little less “exhausting” for individuals, and try to avoid a situation where people feel obligated to block him in the first place.
Specifically:
- comments about formating will mostly just collapse to a recommendation to use
nixpkgs-fmtto format the file in question. And avoid commenting on formatting that doesn’t really affect readability (still subjective, but avoid death by a thousand cuts). - use of saved replies (when applicable) to create more detailed responses, to help identify the issue, give some justification to the change, and provide guidance on remedying an issue; instead of terse responses just identifying in an issue, and may come off as a rude command without context.
There’s still a lot of commentary that he provides which would improve nixpkgs, as well as his dedication to providing reviews for nixpkgs. So I don’t want him to be ostracized and unable to add input PR reviews. Nixpkgs is in need of more committer / reviewer engagement, and I don’t see any ill intent in his participation with Nixpkgs.