I think “peers” represent indeed a group of active committers, but some non-committers are also involved and stick around.
In this instance, we are looking at ways to decrease drastically the amount of time sinks that committers and to a larger extent some reviewers are going through.
Well, I am really sorry for your experience, as you can see, someone who contributed trivial commits to OfBorg gave their opinion on this thing without taking into account the other issue, it’s not the first instance this person has not taken the time to ponders the situation and rushed out to impose their conclusion on things.
For example, @JulienMalka who is someone I work on a daily basis in real life, suggested another way to look at your issue, but it seems the deed was already done.
I would say in general that this is a good example of something that can easily be answered by me as a product manager (debatable), if you want:
I believe that the PR is trivial and is a good addition in general, but OfBorg is not in a sufficiently good shape to accept this PR without evaluation of its impact on the build capacity, which should be reported inside this PR as data. So actually, what is, a seemingly trivial PR, is definitely not IMHO.
We can press ‘merge’ and have the consequences, but they will be very problematic for active contributors like us who are dealing with OfBorg having a too large queue, stopping us in our tracks.
What is even more annoying is that there’s a political dimension to your PR, it has not been discussed, yet I imagine, but if we think from a resource prioritization standpoint, it does not make sense to build unfree packages rather than let’s say exotic platforms like Musl in our CI.
Finally, there is the legal dimension of your PR, what does it mean to build this contents and throw it away — we already had overzealous people coming at us for the fact we were rebuilding their free (!!) software with our CI, I cannot imagine what annoying extra incident it may create with unfree software if it was too “public”.
Though, unfree package in CI is a valid concern and requires a more involved focused group to determine where does the project stand in maturity to support or not an action in that area. At the moment, I believe it’s unrealistic before we secure legal means for the project (because if someone wants to fuck around, they will be able to, and we don’t want to find an IP lawyer on a last minute). At least, that’s my 2 cents.
So I apologize, this was in fact a very complicated issue to deal with and requires coordination with the stakeholders of our legal existence, i.e. the Foundation IMHO.
Here’s the interesting fact: no one has really the keys… OfBorg is in a very precarious position.
I believe what was lacking is that what I have been trying to formalize in terms of “strategic goals inside nixpkgs”, if such a thing would exist, it would take the form of a large big picture set of goals which could be detailed at the issue level we have to take care of, to contribute in a larger form to the project.
And I think you had a mix of:
(a) picking the wrong “easy” issue
(b) picking the wrong project: OfBorg is a special case among all cases, even Hydra is kinda different (!!)
(c) not escalating to more folks (committers/reviewers/any relevant person, you can check the infra team for example for that) who may have a different opinion: committers do not monitor the OfBorg repo and probably who does probably miss stuff that is not directly addressed to them (*)
Nevertheless, it’s not an excuse for saying that the process for you, from what I am seeing, was awful. And I reiterate my apologies, this is exactly what I want to curb.
This Open Collective is about bringing the financial means to curb this, and it sprinkles a bit of that prioritization vision, you will also get better contribution experience in such projects because you won’t have drive-by random contributors (no matter how much prolific they can be, this is irrelevant) who are not necessarily involved in OfBorg operations, which is not a bad thing, but I feel like you deserved the answer I put above on the unfree topic.
Onto the “what can I pick up as a beginner task to help around”, this is a hard one. The way I see it is that we need to get experienced community members to take the time to reduce the barrier to entry to contribution to our stuff, to open it up to people like you and help you towards making satisfying contributions if you want to.
But doing so requires addressing the strategical issues I am talking about first. I am not against doing both in parallel, but I am laser focused on strategical issues if you will because I am convinced this is what put an end to those situations.
I may be wrong, and I would be gladly proven wrong if my vision of the situation is partial.
Either case, I apologize if you feel like there’s a “peer” group that is blocking access to contributions, this is a subject that interestingly @JulienMalka brought regarding the existence of a “core group” at NixCon (Julien: "NixCon feeback" - NixOS Paris server). I don’t want this for the NixOS community, and I am dedicated through those initiatives to lower the barrier to entry and lower the requirements to work on anything in nixpkgs and increase diversity of our community through that.
This is my commitment in my dedication through what I do, i.e. not only driving my changes as a nixpkgs contributor, but ensuring that you get to feel welcomed in this community and understand how to navigate through all of this without feeling there’s a group of folks that gets to decide unilaterally and you have no say in this.