makeBinaryWrapper change, 70586 affected packages

Edit: This PR has been closed, and replaced by a new one which, rather than changing an existing flag, just adds an --add-flag so that at least makeBinaryWrapper can accept flags with spaces in some way.


Old post:

This affects a massive portion of nixpkgs and I figured it deserves a post here.

(when I say massive, I mean Package: added 0, removed 0, changed 70586, Rebuild: linux 60153, darwin 53012 )

This pr needs review.

–add-flags and --append-flags used to not accept arguments with spaces properly, it ALWAYS split on them, regardless of quoting.

This fixes that to be in line with pkgs.makeWrapper

Also:

It needs some mac users to run the tests for makeBinaryWrapper against the PR commit hash

For that you may use

nix build -v github:nixos/nixpkgs/5368af0a086372d4fd52bd015db5749274469a5e#tests.makeBinaryWrapper

And then let us know how that goes.

3 Likes