Nixf-tidy: static/semantic linter for nix, help me to integrate it with Github Actions (PR Reviews?)

[piegames]

Indeed, the formatting RFC has little to nothing to do with linting except that we need both. I did a topic on linting, it contains a good collection of already existing linting tools. In the end, it’s not the specific tool which matters, but the need for actually integrating this into Nixpkgs.

We need Nixpkgs linting

The amount of person-hours we currently waste on manually reviewing things which could be automated is not okay. The advantages of automated code quality checking: It reduces the amount of back and forth between author and reviewer, because a lot of fixes can be done locally already. This reduces stress and is faster due to having a lower round trip latency. It reduces the amount of nitpicky review comments, increasing the signal-to-noise ratio for actually important review comments. Higher qu…