If you want to be passive-aggressive and not contribute anything, you’re not going to get anywhere. Good luck.
11 Likes
It is not necessary for it to function, it is necessary for it to function correctly though (without git we can’t set the .version-suffix file that it is used by some tools), so from your own definition a warning log is exactly what we want there.
1 Like
Nice one!, thanks for opening this!
It being absent from NixOS and the official ISOs always struck me as a bizarre choice, and it actually annoyed me enough as a brand new user of Nix/NixOS/git (yes, all 3 simultaneously) that I ended up spending far too much time trying to work out how to make a custom ISO.
If the reasoning was solely the size of the package, I kinda feel like that’s backwards - given where we are now with storage.
If someone wants to create an extremely minimal installation/ISO, then surely that should be a task for an individual, rather than a default (IMO).
1 Like
I think it was more about the download size rather than storage. But NixOS is already quite network-heavy, and we may be better off as you said creating a separate super-minimal ISO.
3 Likes
More like cache size. We’ve been putting some effort recently into reducing the amount of space the ISO takes up on the binary cache. It’s one of the bigger build products in every Hydra eval, and space usage on S3 is something that has been challenging for the Foundation to keep funded.
I’ll try and figure out if including git comes with a noticeable size increase.
2 Likes
Apparently it isn’t absent from the ISOs since last year.
2 Likes
Good luck with what? Get anywhere with what? I certainly wasn’t hoping for anything from you in this thread. I have what I was looking to understand which is that the package isn’t correctly packaged (author directly states that the script doesn’t function correctly without it), and if I get a moment I’ll see if I can help with this. FWIW I think talking about whether git is or isn’t included in the ISO is a red-herring. nixos-rebuild should function without warnings standalone. I think given that all it does is call rev-parse HEAD there are probably ways to achieve that without the git binary at all.
Hey, I was wondering if there isn’t any way to use another program when passing --sudo, I wanted to use run0 but a option would be useful for doas as well.
1 Like
I would definitely welcome a PR here. It is not something that I am interested in working myself since I don’t use either run0 or doas, so it is difficult for me to test that it is working correctly.
2 Likes
I think what you may be looking for is Dead man switch for nixos-rebuild switch / boot
I haven’t tried it, but it looks close to what you would like to see in the rewrite as feature