PR Approved - Needs Merging protonvpn-cli-ng

JeffLabonte · March 24, 2020, 11:55pm

Hello guys!

I just wanted to put this out there. I have a PR still pending merging. That PR was created 20 days ago

github.com/NixOS/nixpkgs

Protonvpn ng update 2.2.0 to 2.2.2

NixOS:master ← JeffLabonte:protonvpn-ng_update_2.2.0_to_2.2.2

opened 04:37PM - 04 Mar 20 UTC

JeffLabonte

+8 -7

###### Motivation for this change I use this VPN and I was getting messages t…elling me to upgrade. I wanted to give this to the community ###### Things done Update version from 2.2.0 to 2.2.2, update the sha256 sum, and add myself as a maintainer of this package. - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS linux) - Built on platform(s) - [x] NixOS - [ ] macOS - [ ] other Linux distributions - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests)) - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nixpkgs-review --run "nixpkgs-review wip"` - [ ] Tested execution of all binary files (usually in `./result/bin/`) - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after) - [ ] Ensured that relevant documentation is up to date - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

Would it be possible to merge it please

Thank you guys!

JeffLabonte · March 25, 2020, 1:00am

Thank you! For the review!!! It has been merged!

JeffLabonte · March 25, 2020, 1:01am

Backports are on the way: The one for 19.09 is there:

github.com/NixOS/nixpkgs

[19.09] protonvpn ng 2.2.0 to 2.2.2

NixOS:release-19.09 ← JeffLabonte:update_protonvpn_ng_2.2.0-with_fix

opened 12:58AM - 25 Mar 20 UTC

JeffLabonte

+6 -5

###### Motivation for this change Make sure the package works for everybody … ###### Things done Backport from PR #81735 - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS linux) - Built on platform(s) - [x] NixOS - [ ] macOS - [ ] other Linux distributions - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests)) - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nixpkgs-review --run "nixpkgs-review wip"` - [ ] Tested execution of all binary files (usually in `./result/bin/`) - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after) - [ ] Ensured that relevant documentation is up to date - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

There was a missing dependency. It has been added to this PR.

JeffLabonte · March 25, 2020, 1:06am

github.com/NixOS/nixpkgs

[20.03] protonvpn-cli-ng: 2.2.0 -> 2.2.2

NixOS:release-20.03 ← JeffLabonte:20.03_update_protonvpn_ng_2.2.0-with_fix

opened 01:06AM - 25 Mar 20 UTC

JeffLabonte

+6 -5

Some changes were made after final review of the package. There was a missing r…untime dependency that was discovered after merge of the backport (cherry picked from commit 9fe4a634c1f3171b356d2fe986deab1b2d5ceda4) Reason: The dependency can make the package work or not ###### Motivation for this change Make sure the package works for everybody ###### Things done Backport from PR #81735 - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS linux) - Built on platform(s) - [ ] NixOS - [ ] macOS - [ ] other Linux distributions - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests)) - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nixpkgs-review --run "nixpkgs-review wip"` - [ ] Tested execution of all binary files (usually in `./result/bin/`) - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after) - [ ] Ensured that relevant documentation is up to date - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).