I recently made a pr for the sway module, however there is no maintainers pinged nor does the package metadata contain any maintainers. One removed himself long ago and shortly there after, the other maintainers got removed from all packages he was maintaining. Do I contact a committer about this and get them to merge it or try to add myself as a maintainer and merge it myself?
1 Like
You cannot merge your own PRs even if you are a maintainer.
It’s been less than a day, just wait.
As for the PR contents, it basically amounts to adding this line:
xdg.portal.extraPortals = [
pkgs.xdg-desktop-portal-gtk
];
This has caused issues with conflicting portals in the past and I don’t think it should be added.
2 Likes
Both niri and hyprland include this in their config and sway especially has a already existing gtk portal config, this is just here to completeness also so you don’t have to go digging around. If you have multiple DEs installed, Gnome adds this packages as well as KDE, so I can’t see conflicts when they already exist for both of them.
I asked here because I am not in the know too much about the review process as this is my first contrib, I had though that no maintainer there is no way for my pr to get merged into the module. But I will wait.
Hyprland does not: nixpkgs/nixos/modules/programs/wayland/hyprland.nix at bcd464ccd2a1a7cd09aa2f8d4ffba83b761b1d0e · NixOS/nixpkgs · GitHub
I appreciate that, and as usual, it can be quite hard to learn the ins and outs of the contribution process to a new project. Asking is fine.
That said, reading the contribution docs top-to-bottom should give you a good idea of the process: nixpkgs/CONTRIBUTING.md at 7956aea0f0073c12903d3cec75df99f0cdfc4d1b · NixOS/nixpkgs · GitHub
If you don’t have a commit bit, and aren’t being obnoxious (which I don’t recommend, even if it’s effective, squeaky wheels and all), it’s rare to get a PR in within less than two weeks IME, no matter how small. Usually it takes me about a month, I’d say, patience is key.
It would help if you added a body to your commit message explaining why you think the change should be applied.
1 Like
Thank you!
Ig il go PR reviews for other people in the meantime.
IIUC to me it looks like the portal is added in wayland-session.nix by default, which the hyprland module imports.
You are right, I missed that. I’m wondering if that is on purpose though as wlrportal is disabled with a comment that hyprland has its own portal…
xdg-desktop-portal-hyprland does not provide a filepicker, they are probably including -gtk for that purpose. I ran into that when I wanted to use the kde portal and noticed that the Gtk one was already on my machine.
Yes, and that is ultimately unrelated to the wayland session setup, since having a file picker isn’t necessary for the compositor’s functionality, and as you say, may conflict with the portal a user actually wants to use.
It’s probably “on purpose” but not thoroughly thought-out.
The underlying issue leading to this is that NixOS modules are hard to document beyond option descriptions, and that the xdg portal and general non-DE wayland session modules aren’t very well designed (in turn partially because there’s no standardization among non-DE compositors, and the X11 stuff we used to rely on for WMs doesn’t apply anymore).
1 Like
I think the purpose is not to immediately lose the file picker or screenshot/screenshare functionality. More of quality of life functionality. I also find it wierd that while also not providing the actual portal package, it forced everything other than screenshare to use gtk which can conflict if you want to use kde. I think documenting problems with multiple portals or adding enable options to include them might make it better.