Hello! I have following problem - I’ve contributed several packages to nixpkgs (full list), but currently I’m technically not a maintainer (not in maintainers list). this prevents me from contributing to community further and i can’t even merge newer versions of packages i added! problem can be seen here and here. would be nice to have some kind of solution, because currently it just looks buggy or weird
Since the PR that contains this commit was merged, you are a maintainer in nixpkgs. But you must explicitly mark yourself as a maintainer of the packages that you want to maintain as well.
As for not being in the maintainers team, you should have gotten an invite to join the organization; if you haven’t, ask on Matrix.
3 Likes
Do note that just being a package maintainer doesn’t let you automatically merge package updates (edit: unless generated by r-ryantm), they still need to be approved by a “committer” (someone with write access). The wording is a little confusing: The GitHub UI sometimes uses “maintainer” to refer to what nixpkgs calls a “committer”.
Being listed as a maintainer for a package does also give you the ability to command the update bot to merge an auto-update PR made by the bot.
4 Likes
More generally, anyone (even a non-committer) who maintains all the packages in the PR and is in the NixOS org can initiate merging PRs made by the update bot (r-ryantm) or any committer, or an auto-backport PR, or even PRs approved by any committer.
So this is no longer true in the way you meant it - the nixpkgs-merge-bot is acting as the committer.
I guess I found the problem:
I received the invite but didn’t seen it because my github is linked to email that I use not so often
would be nice to get another one
1 Like
In order to recieve a new invite, you have to ask in the nixos org owners matrix channel: https://matrix.to/#/#org_owners:nixos.org
I’m concerned by this. Maintainers need to be contactable. If a maintainer gets at-mentioned in an issue about their package, we expect them to see it.
3 Likes
That’s what Sign in to GitHub · GitHub is for.
Do invites appear on that page? If so, then my concern stands, since OP clearly wasn’t checking that interface either. If not, good point.
1 Like
already did that, still 0 replies
invitations are email-only, you don’t see them on github, even if you use it everyday
1 Like
No but mentions.
Some text for the limit