PRs already reviewed

zookatron · April 10, 2019, 3:07am

~~merge: https://github.com/NixOS/nixpkgs/pull/57359~~
~~merge: https://github.com/NixOS/nixpkgs/pull/58615~~
~~add tag “status: wait-for-upstream”: https://github.com/NixOS/nixpkgs/pull/54179~~

NRHelmi · April 11, 2019, 12:05pm

let’s check this one
merge: aws-xray-daemon-V3.0.0 | awx-xray-daemon: init at V3.0.0 by NRHelmi · Pull Request #53565 · NixOS/nixpkgs · GitHub

timokau · April 11, 2019, 12:59pm

@NRHelmi please review the list of requirements for PRs to post here. I understand that you’re probably frustrated, especially since your first contribution has been sitting there for 3 months. You’re encouraged to

ping someone you think might be qualified/interested to review in the PR. Infinisil has already reviewed it once and may be willing to give it another look if you remind him
ask for a review on IRC or on discourse. Maybe start another iteration of “PRs ready for review”

Unfortunately I’m not very qualified to review nixos modules myself and there is one outstanding comment by Infinisil (aws-xray-daemon-V3.0.0 | awx-xray-daemon: init at V3.0.0 by NRHelmi · Pull Request #53565 · NixOS/nixpkgs · GitHub) who has much more experience with that than I do.

Izorkin · April 19, 2019, 6:17am

Please check/merge:
https://github.com/NixOS/nixpkgs/pull/57752
https://github.com/NixOS/nixpkgs/pull/57429

timokau · April 20, 2019, 11:14am

Those PRs both have merge conflicts, so are not ready to merge. They are also from nixpkgs members, so posting them here is not necessary (they can merge themselves after you’ve given a positive review).

c00w · April 21, 2019, 3:13am

~~merge - https://github.com/NixOS/nixpkgs/pull/59942~~
~~merge - https://github.com/NixOS/nixpkgs/pull/59971~~
~~merge - https://github.com/NixOS/nixpkgs/pull/59899~~
~~merge - https://github.com/NixOS/nixpkgs/pull/59950~~
merge - tmux: 2.8 -> 2.9 by xrelkd · Pull Request #60194 · NixOS/nixpkgs · GitHub
merge - ipfs: 0.4.19 -> 0.4.20 by elitak · Pull Request #60148 · NixOS/nixpkgs · GitHub
merge - Datadog: update packages by Izorkin · Pull Request #59872 · NixOS/nixpkgs · GitHub

apeyroux · May 14, 2019, 6:49pm

If someone can validate or propose a comment for this pr?

It fixes a bug that prevents to use diskImageFuns.debian9x86_64 and thus generate debian9 debs for example. The workaround is to use the debian8 image for the moment.

https://github.com/NixOS/nixpkgs/pull/60868

Regards

Ekleog · June 13, 2019, 4:34pm

Done

davidak via Nix community nixos1@discoursemail.com writes:

gazally · June 27, 2019, 2:57pm

I left a review for this one:

Merge: ~~https://github.com/NixOS/nixpkgs/pull/58649~~

These two have both been reviewed by someone else, but could be acted on quickly by a committer:

Close: ~~https://github.com/NixOS/nixpkgs/pull/37353~~
Tag with WIP: ~~https://github.com/NixOS/nixpkgs/pull/52424~~

Reasoning: The description of #52424 mentions that it obsoletes #37353, and the most recent comment in #52424 says the contributor is currently testing an additional proposed change.