PRs already reviewed

oxij · March 21, 2025, 10:25am

treewide: fix some more `sourceRoot`s

NixOS:master ← oxij:tree/source-root-continues-4

opened 01:46PM - 19 Mar 25 UTC

Continuation of #248528 with more things that were since discovered to be broken… with non-default values of `config.fetchedSourceNameDefault` of #49862. I.e. this replaces more references to `fetchzip`'s "source" in `sourceRoot` package attribute with `src.name` and similar. Should be a noop (up to some tiny changes causing micro-rebuilds).

github.com/NixOS/nixpkgs

treewide: fix and improve some `src`s

NixOS:master ← oxij:tree/fix-sources

opened 11:57AM - 19 Mar 25 UTC

oxij

+38 -26

This fixes some source-related build failures I noticed while building nixpkgs w…ithout using cache.nixos.org, and then adds some related improvements on top, to make these particular issues less likely in the future. ## Things done - Built on platform(s) - [X] x86_64-linux - With - [X] `sandbox = true` - [X] This should be a noop, since no hashes change. - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md). --- Add a :+1: [reaction] to [pull requests you find important]. [reaction]: https://github.blog/2016-03-10-add-reactions-to-pull-requests-issues-and-comments/ [pull requests you find important]: https://github.com/NixOS/nixpkgs/pulls?q=is%3Aopen+sort%3Areactions-%2B1-desc