PRs already reviewed

Please check/merge:
https://github.com/NixOS/nixpkgs/pull/57752
https://github.com/NixOS/nixpkgs/pull/57429

Those PRs both have merge conflicts, so are not ready to merge. They are also from nixpkgs members, so posting them here is not necessary (they can merge themselves after you’ve given a positive review).

~~merge - https://github.com/NixOS/nixpkgs/pull/59942~~
~~merge - https://github.com/NixOS/nixpkgs/pull/59971~~
~~merge - https://github.com/NixOS/nixpkgs/pull/59899~~
~~merge - https://github.com/NixOS/nixpkgs/pull/59950~~
merge - tmux: 2.8 -> 2.9 by xrelkd · Pull Request #60194 · NixOS/nixpkgs · GitHub
merge - ipfs: 0.4.19 -> 0.4.20 by elitak · Pull Request #60148 · NixOS/nixpkgs · GitHub
merge - Datadog: update packages by Izorkin · Pull Request #59872 · NixOS/nixpkgs · GitHub

If someone can validate or propose a comment for this pr?

It fixes a bug that prevents to use diskImageFuns.debian9x86_64 and thus generate debian9 debs for example. The workaround is to use the debian8 image for the moment.

https://github.com/NixOS/nixpkgs/pull/60868

Regards

Done :slight_smile:

davidak via Nix community nixos1@discoursemail.com writes:

I left a review for this one:

Merge: https://github.com/NixOS/nixpkgs/pull/58649

These two have both been reviewed by someone else, but could be acted on quickly by a committer:

Close: https://github.com/NixOS/nixpkgs/pull/37353
Tag with WIP: https://github.com/NixOS/nixpkgs/pull/52424

Reasoning: The description of #52424 mentions that it obsoletes #37353, and the most recent comment in #52424 says the contributor is currently testing an additional proposed change.

1 Like

Merge: https://github.com/NixOS/nixpkgs/pull/55361
Close: https://github.com/NixOS/nixpkgs/pull/63476 because this change was included in #63876 which has been merged.

I’m posting here my own PR, because I got 2 positive reviews, but I think it got lost:
merge: ~~https://github.com/NixOS/nixpkgs/pull/63942~~

1 Like

Close: https://github.com/NixOS/nixpkgs/issues/39388
Close: https://github.com/NixOS/nixpkgs/pull/52632

Reason: These have been obsoleted and resolved by #60250.

Close: ~~Issues · NixOS/nixpkgs · GitHub

~~Close: https://github.com/NixOS/nixpkgs/pull/64510~~
~~Merge: https://github.com/NixOS/nixpkgs/pull/64482~~

~~Merge: https://github.com/NixOS/nixpkgs/pull/64614~~

Merge: scylladb: init at 3.0.5 by workflow · Pull Request #61438 · NixOS/nixpkgs · GitHub

looks good, already been reviewed and the comments addressed.

Two approvals: codespell: init at 1.15.0 by JohnAZoidberg · Pull Request #63673 · NixOS/nixpkgs · GitHub

Merge: plata-theme: 0.8.3 -> 0.8.7 by tadfisher · Pull Request #64186 · NixOS/nixpkgs · GitHub
Merge: ktlint: 0.33.0 -> 0.34.0 by r-ryantm · Pull Request #65094 · NixOS/nixpkgs · GitHub

~~Merge: https://github.com/NixOS/nixpkgs/pull/64932~~

Merge: pythonPackages.diofant: init at 0.10.0 by suhr · Pull Request #65234 · NixOS/nixpkgs · GitHub

It would be nice if someone how had some awareness about mpd to review the following PR

review: mpd: 0.20.13 -> 0.21.16 by tobim · Pull Request #57608 · NixOS/nixpkgs · GitHub

And a slightly less invasive version mpd: nixos module support for standard users by peterhoeg · Pull Request #62771 · NixOS/nixpkgs · GitHub

1 Like

That would probably reach a better target audience in PRs ready for review _ - #21 by lilyball :slight_smile: