PRs already reviewed

Done :slight_smile:

davidak via Nix community nixos1@discoursemail.com writes:

I left a review for this one:

Merge: https://github.com/NixOS/nixpkgs/pull/58649

These two have both been reviewed by someone else, but could be acted on quickly by a committer:

Close: https://github.com/NixOS/nixpkgs/pull/37353
Tag with WIP: https://github.com/NixOS/nixpkgs/pull/52424

Reasoning: The description of #52424 mentions that it obsoletes #37353, and the most recent comment in #52424 says the contributor is currently testing an additional proposed change.

1 Like

Merge: https://github.com/NixOS/nixpkgs/pull/55361
Close: https://github.com/NixOS/nixpkgs/pull/63476 because this change was included in #63876 which has been merged.

I’m posting here my own PR, because I got 2 positive reviews, but I think it got lost:
merge: https://github.com/NixOS/nixpkgs/pull/63942

1 Like

Close: https://github.com/NixOS/nixpkgs/issues/39388
Close: https://github.com/NixOS/nixpkgs/pull/52632

Reason: These have been obsoleted and resolved by #60250.

Close: https://github.com/NixOS/nixpkgs/issues/61672

Close: https://github.com/NixOS/nixpkgs/pull/64510
Merge: https://github.com/NixOS/nixpkgs/pull/64482

Merge: https://github.com/NixOS/nixpkgs/pull/64614

Merge: https://github.com/NixOS/nixpkgs/pull/61438

looks good, already been reviewed and the comments addressed.

Two approvals: https://github.com/NixOS/nixpkgs/pull/63673

Merge: https://github.com/NixOS/nixpkgs/pull/64186
Merge: https://github.com/NixOS/nixpkgs/pull/65094

Merge: https://github.com/NixOS/nixpkgs/pull/64932

Merge: https://github.com/NixOS/nixpkgs/pull/65234

It would be nice if someone how had some awareness about mpd to review the following PR

review: https://github.com/NixOS/nixpkgs/pull/57608

And a slightly less invasive version https://github.com/NixOS/nixpkgs/pull/62771

1 Like

That would probably reach a better target audience in PRs ready for review [May 2019] :slight_smile:

Yeah, though reference to PRs ready for review [May 2019] it’s not even May anymore :smile:

An influx of requests to review PRs here because I guess GitHub isn’t really lending it’s hand to this will be problematic eventually. i.e 30 PRs ready for review threads all about the same thing.

Perhaps we need a topic.

Overall the topic seems to be relatively successful. A big thanks to @matthewbauer who I believe stated the idea some time ago. PRs slip through the cracks on github sometimes and until our tagging better identifies these and/or reviewers make use of tagging/searching features a topic like this works well. +1 for renaming/pinning.

Merge - https://github.com/NixOS/nixpkgs/pull/65579

I need some help/review for updating vagrant : https://github.com/NixOS/nixpkgs/pull/64302

The Gemfile/Gemfile.lock were removed a while back and now it is unclear how to proceed to update the package since it seems to be the usual ruby/gem thing with bundix. I got something working but nobody wants to look at my PR :smiley: