PRs already reviewed

Development
25

Done :slight_smile:

davidak via Nix community nixos1@discoursemail.com writes:

26

I left a review for this one:

Merge: https://github.com/NixOS/nixpkgs/pull/58649

These two have both been reviewed by someone else, but could be acted on quickly by a committer:

Close: https://github.com/NixOS/nixpkgs/pull/37353
Tag with WIP: https://github.com/NixOS/nixpkgs/pull/52424

Reasoning: The description of #52424 mentions that it obsoletes #37353, and the most recent comment in #52424 says the contributor is currently testing an additional proposed change.

1 Like
27

Merge: https://github.com/NixOS/nixpkgs/pull/55361
Close: https://github.com/NixOS/nixpkgs/pull/63476 because this change was included in #63876 which has been merged.

28

I’m posting here my own PR, because I got 2 positive reviews, but I think it got lost:
merge: ~~https://github.com/NixOS/nixpkgs/pull/63942~~

1 Like
29

Close: https://github.com/NixOS/nixpkgs/issues/39388
Close: https://github.com/NixOS/nixpkgs/pull/52632

Reason: These have been obsoleted and resolved by #60250.

31

Close: ~~Issues · NixOS/nixpkgs · GitHub

32

~~Close: https://github.com/NixOS/nixpkgs/pull/64510~~
~~Merge: https://github.com/NixOS/nixpkgs/pull/64482~~

33

~~Merge: https://github.com/NixOS/nixpkgs/pull/64614~~

34

Merge: scylladb: init at 3.0.5 by workflow · Pull Request #61438 · NixOS/nixpkgs · GitHub

looks good, already been reviewed and the comments addressed.

36

Two approvals: codespell: init at 1.15.0 by JohnAZoidberg · Pull Request #63673 · NixOS/nixpkgs · GitHub

37

Merge: plata-theme: 0.8.3 -> 0.8.7 by tadfisher · Pull Request #64186 · NixOS/nixpkgs · GitHub
Merge: ktlint: 0.33.0 -> 0.34.0 by r-ryantm · Pull Request #65094 · NixOS/nixpkgs · GitHub

39

~~Merge: https://github.com/NixOS/nixpkgs/pull/64932~~

40

Merge: pythonPackages.diofant: init at 0.10.0 by suhr · Pull Request #65234 · NixOS/nixpkgs · GitHub

41

It would be nice if someone how had some awareness about mpd to review the following PR

review: mpd: 0.20.13 -> 0.21.16 by tobim · Pull Request #57608 · NixOS/nixpkgs · GitHub

42

And a slightly less invasive version mpd: nixos module support for standard users by peterhoeg · Pull Request #62771 · NixOS/nixpkgs · GitHub

1 Like
43

That would probably reach a better target audience in PRs ready for review _ - #21 by lilyball :slight_smile:

44

Yeah, though reference to PRs ready for review _ - #30 by lilyball it’s not even May anymore :smile:

An influx of requests to review PRs here because I guess GitHub isn’t really lending it’s hand to this will be problematic eventually. i.e 30 PRs ready for review threads all about the same thing.

Perhaps we need a topic.

45

Overall the topic seems to be relatively successful. A big thanks to @matthewbauer who I believe stated the idea some time ago. PRs slip through the cracks on github sometimes and until our tagging better identifies these and/or reviewers make use of tagging/searching features a topic like this works well. +1 for renaming/pinning.

46

Merge - plata-theme: 0.8.7 -> 0.8.8 by tadfisher · Pull Request #65579 · NixOS/nixpkgs · GitHub

47

I need some help/review for updating vagrant : vagrant: 2.2.3 -> 2.2.5 by angristan · Pull Request #64302 · NixOS/nixpkgs · GitHub

The Gemfile/Gemfile.lock were removed a while back and now it is unclear how to proceed to update the package since it seems to be the usual ruby/gem thing with bundix. I got something working but nobody wants to look at my PR :smiley: