let’s check this one
let’s check this one
@NRHelmi please review the list of requirements for PRs to post here. I understand that you’re probably frustrated, especially since your first contribution has been sitting there for 3 months. You’re encouraged to
- ping someone you think might be qualified/interested to review in the PR. Infinisil has already reviewed it once and may be willing to give it another look if you remind him
- ask for a review on IRC or on discourse. Maybe start another iteration of “PRs ready for review”
Unfortunately I’m not very qualified to review nixos modules myself and there is one outstanding comment by Infinisil (https://github.com/NixOS/nixpkgs/pull/53565#discussion_r253309876) who has much more experience with that than I do.
Those PRs both have merge conflicts, so are not ready to merge. They are also from nixpkgs members, so posting them here is not necessary (they can merge themselves after you’ve given a positive review).
merge - https://github.com/NixOS/nixpkgs/pull/59942
merge - https://github.com/NixOS/nixpkgs/pull/59971
merge - https://github.com/NixOS/nixpkgs/pull/59899
merge - https://github.com/NixOS/nixpkgs/pull/59950
merge - https://github.com/NixOS/nixpkgs/pull/60194
merge - https://github.com/NixOS/nixpkgs/pull/60148
merge - https://github.com/NixOS/nixpkgs/pull/59872
If someone can validate or propose a comment for this pr?
It fixes a bug that prevents to use diskImageFuns.debian9x86_64 and thus generate debian9 debs for example. The workaround is to use the debian8 image for the moment.
(hope it’s ok to link issues as well)
davidak via Nix community email@example.com writes:
I left a review for this one:
These two have both been reviewed by someone else, but could be acted on quickly by a committer:
I’m posting here my own PR, because I got 2 positive reviews, but I think it got lost:
Reason: These have been obsoleted and resolved by #60250.
looks good, already been reviewed and the comments addressed.
Two approvals: https://github.com/NixOS/nixpkgs/pull/63673