PRs already reviewed

let’s check this one
merge: https://github.com/NixOS/nixpkgs/pull/53565

@NRHelmi please review the list of requirements for PRs to post here. I understand that you’re probably frustrated, especially since your first contribution has been sitting there for 3 months. You’re encouraged to

  • ping someone you think might be qualified/interested to review in the PR. Infinisil has already reviewed it once and may be willing to give it another look if you remind him
  • ask for a review on IRC or on discourse. Maybe start another iteration of “PRs ready for review”

Unfortunately I’m not very qualified to review nixos modules myself and there is one outstanding comment by Infinisil (https://github.com/NixOS/nixpkgs/pull/53565#discussion_r253309876) who has much more experience with that than I do.

2 Likes

Please check/merge:


Those PRs both have merge conflicts, so are not ready to merge. They are also from nixpkgs members, so posting them here is not necessary (they can merge themselves after you’ve given a positive review).

merge - https://github.com/NixOS/nixpkgs/pull/59942
merge - https://github.com/NixOS/nixpkgs/pull/59971
merge - https://github.com/NixOS/nixpkgs/pull/59899
merge - https://github.com/NixOS/nixpkgs/pull/59950
merge - https://github.com/NixOS/nixpkgs/pull/60194
merge - https://github.com/NixOS/nixpkgs/pull/60148
merge - https://github.com/NixOS/nixpkgs/pull/59872

If someone can validate or propose a comment for this pr?

It fixes a bug that prevents to use diskImageFuns.debian9x86_64 and thus generate debian9 debs for example. The workaround is to use the debian8 image for the moment.

Regards

close https://github.com/NixOS/nixpkgs/issues/24250

(hope it’s ok to link issues as well)

Done :slight_smile:

davidak via Nix community nixos1@discoursemail.com writes:

I left a review for this one:

Merge: https://github.com/NixOS/nixpkgs/pull/58649

These two have both been reviewed by someone else, but could be acted on quickly by a committer:

Close: https://github.com/NixOS/nixpkgs/pull/37353
Tag with WIP: https://github.com/NixOS/nixpkgs/pull/52424

Reasoning: The description of #52424 mentions that it obsoletes #37353, and the most recent comment in #52424 says the contributor is currently testing an additional proposed change.

1 Like

Merge: https://github.com/NixOS/nixpkgs/pull/55361
Close: https://github.com/NixOS/nixpkgs/pull/63476 because this change was included in #63876 which has been merged.

I’m posting here my own PR, because I got 2 positive reviews, but I think it got lost:
merge: https://github.com/NixOS/nixpkgs/pull/63942

1 Like

Close: https://github.com/NixOS/nixpkgs/issues/39388
Close: https://github.com/NixOS/nixpkgs/pull/52632

Reason: These have been obsoleted and resolved by #60250.

Merge: https://github.com/NixOS/nixpkgs/pull/60518

Close: https://github.com/NixOS/nixpkgs/issues/61672

Close: https://github.com/NixOS/nixpkgs/pull/64510
Merge: https://github.com/NixOS/nixpkgs/pull/64482

Merge: https://github.com/NixOS/nixpkgs/pull/64614

Merge: https://github.com/NixOS/nixpkgs/pull/61438

looks good, already been reviewed and the comments addressed.

Two approvals: https://github.com/NixOS/nixpkgs/pull/63673

Merge: https://github.com/NixOS/nixpkgs/pull/64186
Merge: https://github.com/NixOS/nixpkgs/pull/65094

Merge: https://github.com/NixOS/nixpkgs/pull/64258