PRs already reviewed

###### Motivation for this change ###### Things done - Built on platform(s) - [x] x86_64-linux - [ ] aarch64-linux - [ ] x86_64-darwin - [ ] aarch64-darwin - [ ] For non-Linux: Is `sandbox = true` set in `nix.conf`? (See [Nix manual](https://nixos.org/manual/nix/stable/#sec-conf-file)) - [x] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests)) - [x] Tested compilation of all packages that depend on this change using `nix-shell -p nixpkgs-review --run "nixpkgs-review wip"` - [x] Tested execution of all binary files (usually in `./result/bin/`) - [21.11 Release Notes (or backporting 21.05 Release notes)](https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md#generating-2111-release-notes) - [ ] (Package updates) Added a release notes entry if the change is major or breaking - [ ] (Module updates) Added a release notes entry if the change is significant - [ ] (Module addition) Added a release notes entry if adding a new NixOS module - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md).

turion · September 6, 2021, 8:59am

github.com/NixOS/nixpkgs

pythonPackages.mysql-connector: Fix on darwin

NixOS:master ← neosimsim:patch-mysql-connector

opened 08:51AM - 20 Jul 21 UTC

neosimsim

+52 -1

###### Motivation for this change python module mysql-conncetor fails to build …on darwin (macOS) https://github.com/NixOS/nixpkgs/issues/130376. ###### Things done Compared with last successful version and found out there was a version bump of mysql-connector which add a strange commit https://github.com/mysql/mysql-connector-python/commit/d1e89fd3d7391084cdf35b0806cb5d2a4b413654 for macOS distributions. Reverting this commit makes the derivatoin work again. - [x] Tested using sandboxing ([nix.useSandbox](https://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](https://nixos.org/nix/manual/#sec-conf-file) on non-NixOS linux) - Built on platform(s) - [x] NixOS - [x] macOS - [x] other Linux distributions - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nixpkgs-review --run "nixpkgs-review wip"` - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md).

julm · September 10, 2021, 3:13pm

Forgotten fixes of mine:

apparmor : nixos/apparmor: allow closure of selected mallocLib, fixes #125415 by ju1m · Pull Request #125966 · NixOS/nixpkgs · GitHub
croc : nixos/croc: harden ProtectProc by ju1m · Pull Request #122460 · NixOS/nixpkgs · GitHub

bobby285271 · September 11, 2021, 11:23am

merge:

julm · September 12, 2021, 4:05pm

Fix for Tor:

~~https://github.com/NixOS/nixpkgs/pull/135626~~

cab · September 14, 2021, 12:39pm

github.com/NixOS/nixpkgs

nixos.system.boot.kernel: stronger constraints for kernelParam type

NixOS:master ← cab404:kernel-params-checking

opened 02:40PM - 12 Aug 21 UTC

cab404

+4 -1

Checks whether all spaces are inside double quotes, thus ensuring that one stri…ng parses as no more than one kernel param.  ###### Motivation for this change Users often add spaces in expressions like "a = 12", and having them parsed as 3 separate params is not user friendly. ###### Things done kernelParams type changed to a string match. - [X] Tested using sandboxing ([nix.useSandbox](https://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](https://nixos.org/nix/manual/#sec-conf-file) on non-NixOS linux) - Built on platform(s) - [X] NixOS - [ ] macOS - [ ] other Linux distributions - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests)) - [ ] Tested compilation of all packages that depend on this change using `nix-shell -p nixpkgs-review --run "nixpkgs-review wip"` - [x] Tested execution of all binary files (usually in `./result/bin/`) - [21.11 Release Notes (or backporting 21.05 Release notes)](https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md#generating-2111-release-notes) - [ ] (Package updates) Added a release notes entry if the change is major or breaking - [x] (Module updates) Added a release notes entry if the change is significant - [ ] (Module addition) Added a release notes entry if adding a new NixOS module - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md).

nappa · September 16, 2021, 7:13pm

This has been reviewed but I think forgotten:

github.com/NixOS/nixpkgs

glm: 0.9.8.5 -> 0.9.9.8

NixOS:master ← smancill:bump-glm

opened 12:28AM - 20 Aug 21 UTC

smancill

+45 -22

###### Motivation for this change Bump abandoned package to close #132479. I don't really use it. I was just skimming through the list of issues to find something I may help with. ###### Things done <details> <summary>Bump version and refactor derivation to make it work</summary> - Use `fetchFromGitHub` to download the archive. - No need for the updated `platform.h` patch. The released archive builds with default `stdenv`. (It may be needed again in the future?) - Use the proper attribute to set CMake flags. - Don't build the (dummy?) libraries. They are not used anyway by any other target nor made available by the `glmConfig.cmake` file. - Build and run the tests now. - Don't define the `GLM_COMPILER` macro on Darwin. Doesn't seem necessary anymore, there are no errors without it. (And it is not even documented what was the original error that required it to be defined.) - Upstream became package-unfriendly and removed the install command, so it needs to be installed manually. - Don't set the now unsupported CMake option `GLM_INSTALL_ENABLE`. - Remove unwanted files from the include directory. - Fix `glmConfig.cmake` with the proper path to the include directory. - While on it, install a custom pkg-config file, since it is trivial. - Don't install unnecessary files as documentation. - Since I practically rewrote the entire derivation and the package is abandoned, add myself as maintainer (I guess?). </details> --------- - Built on platform(s) - [X] x86_64-linux - [ ] aarch64-linux - [X] x86_64-darwin - [ ] aarch64-darwin - [X] For non-Linux: Is `sandbox = true` set in `nix.conf`? (See [Nix manual](https://nixos.org/manual/nix/stable/#sec-conf-file)) - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests)) - [ ] Tested compilation of all packages that depend on this change using `nix-shell -p nixpkgs-review --run "nixpkgs-review wip"` - [ ] Tested execution of all binary files (usually in `./result/bin/`) - [21.11 Release Notes (or backporting 21.05 Release notes)](https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md#generating-2111-release-notes) - [ ] (Package updates) Added a release notes entry if the change is major or breaking - [ ] (Module updates) Added a release notes entry if the change is significant - [ ] (Module addition) Added a release notes entry if adding a new NixOS module - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md).

superherointj · October 19, 2021, 7:52pm

~~https://github.com/NixOS/nixpkgs/pull/142082~~ DONE

superherointj · October 20, 2021, 3:10pm

~~https://github.com/NixOS/nixpkgs/pull/142358~~ DONE

WolfangAukang · October 21, 2021, 1:14pm

~~https://github.com/NixOS/nixpkgs/pull/134855~~

~~https://github.com/NixOS/nixpkgs/pull/135614~~

~~https://github.com/NixOS/nixpkgs/pull/135647~~

~~https://github.com/NixOS/nixpkgs/pull/137102~~

WolfangAukang · October 21, 2021, 3:36pm

~~https://github.com/NixOS/nixpkgs/pull/133891~~

~~https://github.com/NixOS/nixpkgs/pull/136742~~

~~https://github.com/NixOS/nixpkgs/pull/136193~~

~~https://github.com/NixOS/nixpkgs/pull/136302~~