PRs already reviewed

turion · September 6, 2021, 8:59am

pythonPackages.mysql-connector: Fix on darwin

NixOS:master ← neosimsim:patch-mysql-connector

opened 08:51AM - 20 Jul 21 UTC

###### Motivation for this change python module mysql-conncetor fails to build …on darwin (macOS) https://github.com/NixOS/nixpkgs/issues/130376. ###### Things done Compared with last successful version and found out there was a version bump of mysql-connector which add a strange commit https://github.com/mysql/mysql-connector-python/commit/d1e89fd3d7391084cdf35b0806cb5d2a4b413654 for macOS distributions. Reverting this commit makes the derivatoin work again. - [x] Tested using sandboxing ([nix.useSandbox](https://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](https://nixos.org/nix/manual/#sec-conf-file) on non-NixOS linux) - Built on platform(s) - [x] NixOS - [x] macOS - [x] other Linux distributions - [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nixpkgs-review --run "nixpkgs-review wip"` - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md).

julm · September 10, 2021, 3:13pm

Forgotten fixes of mine:

apparmor : nixos/apparmor: allow closure of selected mallocLib, fixes #125415 by ju1m · Pull Request #125966 · NixOS/nixpkgs · GitHub
croc : nixos/croc: harden ProtectProc by ju1m · Pull Request #122460 · NixOS/nixpkgs · GitHub

bobby285271 · September 11, 2021, 11:23am

merge:

julm · September 12, 2021, 4:05pm

Fix for Tor:

~~https://github.com/NixOS/nixpkgs/pull/135626~~

cab · September 14, 2021, 12:39pm

github.com/NixOS/nixpkgs

nixos.system.boot.kernel: stronger constraints for kernelParam type

NixOS:master ← cab404:kernel-params-checking

opened 02:40PM - 12 Aug 21 UTC

cab404

+4 -1

Checks whether all spaces are inside double quotes, thus ensuring that one stri…ng parses as no more than one kernel param.  ###### Motivation for this change Users often add spaces in expressions like "a = 12", and having them parsed as 3 separate params is not user friendly. ###### Things done kernelParams type changed to a string match. - [X] Tested using sandboxing ([nix.useSandbox](https://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](https://nixos.org/nix/manual/#sec-conf-file) on non-NixOS linux) - Built on platform(s) - [X] NixOS - [ ] macOS - [ ] other Linux distributions - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests)) - [ ] Tested compilation of all packages that depend on this change using `nix-shell -p nixpkgs-review --run "nixpkgs-review wip"` - [x] Tested execution of all binary files (usually in `./result/bin/`) - [21.11 Release Notes (or backporting 21.05 Release notes)](https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md#generating-2111-release-notes) - [ ] (Package updates) Added a release notes entry if the change is major or breaking - [x] (Module updates) Added a release notes entry if the change is significant - [ ] (Module addition) Added a release notes entry if adding a new NixOS module - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md).

nappa · September 16, 2021, 7:13pm

This has been reviewed but I think forgotten:

github.com/NixOS/nixpkgs

glm: 0.9.8.5 -> 0.9.9.8

NixOS:master ← smancill:bump-glm

opened 12:28AM - 20 Aug 21 UTC

smancill

+45 -22

###### Motivation for this change Bump abandoned package to close #132479. I don't really use it. I was just skimming through the list of issues to find something I may help with. ###### Things done <details> <summary>Bump version and refactor derivation to make it work</summary> - Use `fetchFromGitHub` to download the archive. - No need for the updated `platform.h` patch. The released archive builds with default `stdenv`. (It may be needed again in the future?) - Use the proper attribute to set CMake flags. - Don't build the (dummy?) libraries. They are not used anyway by any other target nor made available by the `glmConfig.cmake` file. - Build and run the tests now. - Don't define the `GLM_COMPILER` macro on Darwin. Doesn't seem necessary anymore, there are no errors without it. (And it is not even documented what was the original error that required it to be defined.) - Upstream became package-unfriendly and removed the install command, so it needs to be installed manually. - Don't set the now unsupported CMake option `GLM_INSTALL_ENABLE`. - Remove unwanted files from the include directory. - Fix `glmConfig.cmake` with the proper path to the include directory. - While on it, install a custom pkg-config file, since it is trivial. - Don't install unnecessary files as documentation. - Since I practically rewrote the entire derivation and the package is abandoned, add myself as maintainer (I guess?). </details> --------- - Built on platform(s) - [X] x86_64-linux - [ ] aarch64-linux - [X] x86_64-darwin - [ ] aarch64-darwin - [X] For non-Linux: Is `sandbox = true` set in `nix.conf`? (See [Nix manual](https://nixos.org/manual/nix/stable/#sec-conf-file)) - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests)) - [ ] Tested compilation of all packages that depend on this change using `nix-shell -p nixpkgs-review --run "nixpkgs-review wip"` - [ ] Tested execution of all binary files (usually in `./result/bin/`) - [21.11 Release Notes (or backporting 21.05 Release notes)](https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md#generating-2111-release-notes) - [ ] (Package updates) Added a release notes entry if the change is major or breaking - [ ] (Module updates) Added a release notes entry if the change is significant - [ ] (Module addition) Added a release notes entry if adding a new NixOS module - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md).

superherointj · October 19, 2021, 7:52pm

~~https://github.com/NixOS/nixpkgs/pull/142082~~ DONE

superherointj · October 20, 2021, 3:10pm

~~https://github.com/NixOS/nixpkgs/pull/142358~~ DONE

WolfangAukang · October 21, 2021, 1:14pm

~~https://github.com/NixOS/nixpkgs/pull/134855~~

~~https://github.com/NixOS/nixpkgs/pull/135614~~

~~https://github.com/NixOS/nixpkgs/pull/135647~~

~~https://github.com/NixOS/nixpkgs/pull/137102~~

WolfangAukang · October 21, 2021, 3:36pm

~~https://github.com/NixOS/nixpkgs/pull/133891~~

~~https://github.com/NixOS/nixpkgs/pull/136742~~

~~https://github.com/NixOS/nixpkgs/pull/136193~~

~~https://github.com/NixOS/nixpkgs/pull/136302~~

WolfangAukang · October 23, 2021, 4:48am

~~https://github.com/NixOS/nixpkgs/pull/141563~~

~~https://github.com/NixOS/nixpkgs/pull/141482~~

~~https://github.com/NixOS/nixpkgs/pull/141313~~

~~https://github.com/NixOS/nixpkgs/pull/141341~~

~~https://github.com/NixOS/nixpkgs/pull/140504~~

WolfangAukang · October 24, 2021, 6:26pm

github.com/NixOS/nixpkgs

gmid: init at 1.7.5

NixOS:master ← sikmir:gmid

opened 06:19PM - 14 Oct 21 UTC

sikmir

+33 -0

###### Motivation for this change [**gmid**](https://github.com/omar-polo/gmid)… is a fast Gemini server written with security in mind. [![Packaging status](https://repology.org/badge/tiny-repos/gmid.svg)](https://repology.org/project/gmid/versions) ###### Things done - Built on platform(s) - [x] x86_64-linux - [ ] aarch64-linux - [ ] x86_64-darwin - [ ] aarch64-darwin - [ ] For non-Linux: Is `sandbox = true` set in `nix.conf`? (See [Nix manual](https://nixos.org/manual/nix/stable/#sec-conf-file)) - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests)) - [ ] Tested compilation of all packages that depend on this change using `nix-shell -p nixpkgs-review --run "nixpkgs-review wip"` - [x] Tested execution of all binary files (usually in `./result/bin/`) - [21.11 Release Notes (or backporting 21.05 Release notes)](https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md#generating-2111-release-notes) - [ ] (Package updates) Added a release notes entry if the change is major or breaking - [ ] (Module updates) Added a release notes entry if the change is significant - [ ] (Module addition) Added a release notes entry if adding a new NixOS module - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md).

github.com/NixOS/nixpkgs

vscode-extensions.hashicorp.terraform: 2.15.0 -> 2.16.0

NixOS:master ← rhoriguchi:vscode-extensions.hashicorp.terraform

opened 09:19PM - 14 Oct 21 UTC

rhoriguchi

+4 -4

###### Motivation for this change ###### Things done - Built on platform…(s) - [X] x86_64-linux - [ ] aarch64-linux - [ ] x86_64-darwin - [ ] aarch64-darwin - [ ] For non-Linux: Is `sandbox = true` set in `nix.conf`? (See [Nix manual](https://nixos.org/manual/nix/stable/#sec-conf-file)) - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests)) - [ ] Tested compilation of all packages that depend on this change using `nix-shell -p nixpkgs-review --run "nixpkgs-review wip"` - [ ] Tested execution of all binary files (usually in `./result/bin/`) - [21.11 Release Notes (or backporting 21.05 Release notes)](https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md#generating-2111-release-notes) - [ ] (Package updates) Added a release notes entry if the change is major or breaking - [ ] (Module updates) Added a release notes entry if the change is significant - [ ] (Module addition) Added a release notes entry if adding a new NixOS module - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md).

github.com/NixOS/nixpkgs

dosbox-staging: init at 0.77.1

NixOS:master ← JoshuaFern:dosbox-staging

opened 12:09AM - 09 Oct 21 UTC

JoshuaFern

+51 -0

###### Motivation for this change dosbox-staging attempts to modernize the DO…SBox codebase by using current development practices and tools, fixing issues, and adding features that better support today's systems. https://github.com/dosbox-staging/dosbox-staging Note on backporting: Probably needs munt 2.5.0 from unstable, 21.05 currently contains munt 2.4.1 ###### Things done - Built on platform(s) - [x] x86_64-linux - [ ] aarch64-linux - [ ] x86_64-darwin - [ ] aarch64-darwin - [ ] For non-Linux: Is `sandbox = true` set in `nix.conf`? (See [Nix manual](https://nixos.org/manual/nix/stable/#sec-conf-file)) - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests)) - [ ] Tested compilation of all packages that depend on this change using `nix-shell -p nixpkgs-review --run "nixpkgs-review wip"` - [x] Tested execution of all binary files (usually in `./result/bin/`) - [21.11 Release Notes (or backporting 21.05 Release notes)](https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md#generating-2111-release-notes) - [ ] (Package updates) Added a release notes entry if the change is major or breaking - [ ] (Module updates) Added a release notes entry if the change is significant - [ ] (Module addition) Added a release notes entry if adding a new NixOS module - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md).

github.com/NixOS/nixpkgs

gensio: 2.2.9 -> 2.3.0

NixOS:master ← r-ryantm:auto-update/gensio

opened 01:34AM - 15 Oct 21 UTC

r-ryantm

+2 -2

Automatic update generated by [nixpkgs-update](https://github.com/ryantm/nixpkgs…-update) tools. This update was made based on information from passthru.updateScript. meta.description for gensio is: "General Stream I/O" meta.homepage for gensio is: "https://sourceforge.net/projects/ser2net/" meta.changelog for gensio is: "" ###### Updates performed - Ran passthru.UpdateScript ###### To inspect upstream changes - [Compare changes on GitHub](https://github.com/cminyard/gensio/compare/v2.2.9...v2.3.0) ###### Impact <details> <summary> Checks done (click to expand) </summary> --- - built on NixOS - The tests defined in `passthru.tests`, if any, passed - /nix/store/yx6zsrr6gy164j2hfp13bay4q5gxg0dz-gensio-2.3.0/bin/gensiot passed the binary check. - 1 of 1 passed binary check by having a zero exit code. - 1 of 1 passed binary check by having the new version present in output. - found 2.3.0 with grep in /nix/store/yx6zsrr6gy164j2hfp13bay4q5gxg0dz-gensio-2.3.0 - found 2.3.0 in filename of file in /nix/store/yx6zsrr6gy164j2hfp13bay4q5gxg0dz-gensio-2.3.0 - directory tree listing: https://gist.github.com/4aba908e81e952196abbd38b3975a01c - du listing: https://gist.github.com/7d640c9645c912097390d37a1685d9c1 --- </details> <details> <summary> Rebuild report (if merged into master) (click to expand) </summary> ``` 7 total rebuild path(s) 2 package rebuild(s) 2 x86_64-linux rebuild(s) 2 i686-linux rebuild(s) 1 x86_64-darwin rebuild(s) 2 aarch64-linux rebuild(s) First fifty rebuilds by attrpath gensio ser2net ``` </details> <details> <summary> Instructions to test this update (click to expand) </summary> --- Either **download from Cachix**: ``` nix-store -r /nix/store/yx6zsrr6gy164j2hfp13bay4q5gxg0dz-gensio-2.3.0 \ --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \ --option trusted-public-keys ' nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs= cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY= ' ``` (The Cachix cache is only trusted for this store-path realization.) For the Cachix download to work, your user must be in the `trusted-users` list or you can use `sudo` since root is effectively trusted. Or, **build yourself**: ``` nix-build -A gensio https://github.com/r-ryantm/nixpkgs/archive/cdb466320a6e9e61eb1a131fbee4cd70377b4bb2.tar.gz ``` After you've downloaded or built it, look at the files and if there are any, run the binaries: ``` ls -la /nix/store/yx6zsrr6gy164j2hfp13bay4q5gxg0dz-gensio-2.3.0 ls -la /nix/store/yx6zsrr6gy164j2hfp13bay4q5gxg0dz-gensio-2.3.0/bin ``` --- </details> ### Pre-merge build results We have automatically built all packages that will get rebuilt due to this change. This gives evidence on whether the upgrade will break dependent packages. Note sometimes packages show up as _failed to build_ independent of the change, simply because they are already broken on the target branch. Result of `nixpkgs-review` run on x86_64-linux [1](https://github.com/Mic92/nixpkgs-review) <details> <summary>2 packages built:</summary> <ul> <li>gensio</li> <li>ser2net</li> </ul> </details> --- ###### Maintainer pings cc @emantor for [testing](https://github.com/ryantm/nixpkgs-update/blob/master/doc/nixpkgs-maintainer-faq.md#r-ryantm-opened-a-pr-for-my-package-what-do-i-do).

github.com/NixOS/nixpkgs

pythonPackages.powerlineMemSegment: kebab-case

NixOS:master ← interruptinuse:rename-powerlinememsegment

opened 07:21PM - 08 Oct 21 UTC

interruptinuse

+2 -1

###### Motivation for this change All `pythonPackages` seem to be named in ke…bab-case. This commit renames `pythonPackages.powerlineMemSegment` to `powerline-mem-segment` and adds a backward compatibility alias to `python-aliases.nix`. ###### Things done - Built on platform(s) - [ ] x86_64-linux - [ ] aarch64-linux - [ ] x86_64-darwin - [ ] aarch64-darwin - [ ] For non-Linux: Is `sandbox = true` set in `nix.conf`? (See [Nix manual](https://nixos.org/manual/nix/stable/#sec-conf-file)) - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests)) - [ ] Tested compilation of all packages that depend on this change using `nix-shell -p nixpkgs-review --run "nixpkgs-review wip"` - [ ] Tested execution of all binary files (usually in `./result/bin/`) - [21.11 Release Notes (or backporting 21.05 Release notes)](https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md#generating-2111-release-notes) - [ ] (Package updates) Added a release notes entry if the change is major or breaking - [ ] (Module updates) Added a release notes entry if the change is significant - [ ] (Module addition) Added a release notes entry if adding a new NixOS module - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md).