PRs already reviewed

Close: https://github.com/NixOS/nixpkgs/issues/39388
Close: https://github.com/NixOS/nixpkgs/pull/52632

Reason: These have been obsoleted and resolved by #60250.

Close: ~~Issues · NixOS/nixpkgs · GitHub

~~Close: https://github.com/NixOS/nixpkgs/pull/64510~~
~~Merge: https://github.com/NixOS/nixpkgs/pull/64482~~

~~Merge: https://github.com/NixOS/nixpkgs/pull/64614~~

Merge: scylladb: init at 3.0.5 by workflow · Pull Request #61438 · NixOS/nixpkgs · GitHub

looks good, already been reviewed and the comments addressed.

Two approvals: codespell: init at 1.15.0 by JohnAZoidberg · Pull Request #63673 · NixOS/nixpkgs · GitHub

Merge: plata-theme: 0.8.3 -> 0.8.7 by tadfisher · Pull Request #64186 · NixOS/nixpkgs · GitHub
Merge: ktlint: 0.33.0 -> 0.34.0 by r-ryantm · Pull Request #65094 · NixOS/nixpkgs · GitHub

~~Merge: https://github.com/NixOS/nixpkgs/pull/64932~~

Merge: pythonPackages.diofant: init at 0.10.0 by suhr · Pull Request #65234 · NixOS/nixpkgs · GitHub

It would be nice if someone how had some awareness about mpd to review the following PR

review: mpd: 0.20.13 -> 0.21.16 by tobim · Pull Request #57608 · NixOS/nixpkgs · GitHub

And a slightly less invasive version mpd: nixos module support for standard users by peterhoeg · Pull Request #62771 · NixOS/nixpkgs · GitHub

1 Like

That would probably reach a better target audience in PRs ready for review _ - #21 by lilyball :slight_smile:

Yeah, though reference to PRs ready for review _ - #30 by lilyball it’s not even May anymore :smile:

An influx of requests to review PRs here because I guess GitHub isn’t really lending it’s hand to this will be problematic eventually. i.e 30 PRs ready for review threads all about the same thing.

Perhaps we need a topic.

Overall the topic seems to be relatively successful. A big thanks to @matthewbauer who I believe stated the idea some time ago. PRs slip through the cracks on github sometimes and until our tagging better identifies these and/or reviewers make use of tagging/searching features a topic like this works well. +1 for renaming/pinning.

Merge - plata-theme: 0.8.7 -> 0.8.8 by tadfisher · Pull Request #65579 · NixOS/nixpkgs · GitHub

I need some help/review for updating vagrant : vagrant: 2.2.3 -> 2.2.5 by angristan · Pull Request #64302 · NixOS/nixpkgs · GitHub

The Gemfile/Gemfile.lock were removed a while back and now it is unclear how to proceed to update the package since it seems to be the usual ruby/gem thing with bundix. I got something working but nobody wants to look at my PR :smiley:

Close (I think?): error message honores nested dots in attribute path elements by qknight · Pull Request #39060 · NixOS/nixpkgs · GitHub
There are significant merge issues, and there hasn’t been any response on the PR in a few weeks. I’m not sure if that is sufficient to close the PR in this community, though.

Merge: https://github.com/NixOS/nixpkgs/pull/63013

Merge: mdbook: 0.1.8 -> 0.3.1 by tazjin · Pull Request #65890 · NixOS/nixpkgs · GitHub
Close old alternative: mdbook: 0.1.8 -> 0.2.0 by dywedir · Pull Request #44494 · NixOS/nixpkgs · GitHub

Merge: spotifyd: update cargoSha256 hash by BenSchZA · Pull Request #66233 · NixOS/nixpkgs · GitHub

1 Like