PRs already reviewed

Minion3665 · December 13, 2022, 8:14pm

https://github.com/NixOS/nixpkgs/pull/205813

Created by a maintainer, approved by 2 people (including 1 maintainer (me))

urandom · December 13, 2022, 10:35pm

https://github.com/NixOS/nixpkgs/pull/158529

urandom · December 14, 2022, 4:45am

https://github.com/NixOS/nixpkgs/pull/206017

drupol · December 14, 2022, 8:22am

https://github.com/NixOS/nixpkgs/pull/205899

djm · December 14, 2022, 4:43pm

https://github.com/NixOS/nixpkgs/pull/205478

Luflosi · December 14, 2022, 10:44pm

https://github.com/NixOS/nixpkgs/pull/190224

djm · December 15, 2022, 8:25am

https://github.com/NixOS/nixpkgs/pull/204952

Shawn8901 · December 15, 2022, 10:27am

Edit:
Does not apply, PR author has given feedback to be working also on a module that should be included.

Not a PR from me, but i am using that code quite a time for my personal nextcloud to get pushs to the desktop client.
There was some discussion in the PR which likely broke the workflow, but its not related to the PR at all.
From my opinion there is nothing against already merging the binary.

https://github.com/NixOS/nixpkgs/pull/201780

robryk · December 15, 2022, 1:53pm

nixos/restic: small enhancements by robryk · Pull Request #204386 · NixOS/nixpkgs · GitHub is a PR from me that got reviewed and ttbomk is just waiting to be merged.

julm · December 15, 2022, 10:34pm

merge: mmsd: init at 1.12.1 with module by ju1m · Pull Request #196965 · NixOS/nixpkgs · GitHub

djm · December 16, 2022, 4:20pm

https://github.com/NixOS/nixpkgs/pull/206395

Majiir · December 16, 2022, 11:34pm

I tested this on my machine. Works as advertised.

https://github.com/NixOS/nixpkgs/pull/200856#pullrequestreview-1221569265

vccs · December 19, 2022, 8:20am

github.com/NixOS/nixpkgs

jabref: 5.7 -> 5.9

NixOS:master ← linsui:jabref

opened 12:47PM - 09 Dec 22 UTC

linsui

+37 -11

###### Description of changes Closes https://github.com/NixOS/nixpkgs/issues/…220470  ###### Things done - Built on platform(s) - [x] x86_64-linux - [ ] aarch64-linux - [ ] x86_64-darwin - [ ] aarch64-darwin - [ ] For non-Linux: Is `sandbox = true` set in `nix.conf`? (See [Nix manual](https://nixos.org/manual/nix/stable/command-ref/conf-file.html)) - [ ] Tested, as applicable: - [NixOS test(s)](https://nixos.org/manual/nixos/unstable/index.html#sec-nixos-tests) (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests)) - and/or [package tests](https://nixos.org/manual/nixpkgs/unstable/#sec-package-tests) - or, for functions and "core" functionality, tests in [lib/tests](https://github.com/NixOS/nixpkgs/blob/master/lib/tests) or [pkgs/test](https://github.com/NixOS/nixpkgs/blob/master/pkgs/test) - made sure NixOS tests are [linked](https://nixos.org/manual/nixpkgs/unstable/#ssec-nixos-tests-linking) to the relevant packages - [ ] Tested compilation of all packages that depend on this change using `nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"`. Note: all changes have to be committed, also see [nixpkgs-review usage](https://github.com/Mic92/nixpkgs-review#usage) - [ ] Tested basic functionality of all binary files (usually in `./result/bin/`) - [23.05 Release Notes (or backporting 22.11 Release notes)](https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md#generating-2305-release-notes) - [ ] (Package updates) Added a release notes entry if the change is major or breaking - [ ] (Module updates) Added a release notes entry if the change is significant - [ ] (Module addition) Added a release notes entry if adding a new NixOS module - [ ] (Release notes changes) Ran `nixos/doc/manual/md-to-db.sh` to update generated release notes - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md).