PRs already reviewed

lilyinstarlight · February 23, 2023, 3:20pm

Also this one has slipped through, but I approved it after working with the author a bit:

https://github.com/NixOS/nixpkgs/pull/208414

GGwpAiushtha · February 26, 2023, 8:06pm

https://github.com/NixOS/nixpkgs/pull/216661

zendo · February 27, 2023, 7:34am

https://github.com/NixOS/nixpkgs/pull/216311

Luflosi · February 27, 2023, 3:57pm

https://github.com/NixOS/nixpkgs/pull/209304

hexagonal-sun · February 27, 2023, 4:24pm

https://github.com/NixOS/nixpkgs/pull/203869

vccs · March 2, 2023, 5:21am

github.com/NixOS/nixpkgs

jabref: 5.7 -> 5.9

NixOS:master ← linsui:jabref

opened 12:47PM - 09 Dec 22 UTC

linsui

+37 -11

###### Description of changes Closes https://github.com/NixOS/nixpkgs/issues/…220470  ###### Things done - Built on platform(s) - [x] x86_64-linux - [ ] aarch64-linux - [ ] x86_64-darwin - [ ] aarch64-darwin - [ ] For non-Linux: Is `sandbox = true` set in `nix.conf`? (See [Nix manual](https://nixos.org/manual/nix/stable/command-ref/conf-file.html)) - [ ] Tested, as applicable: - [NixOS test(s)](https://nixos.org/manual/nixos/unstable/index.html#sec-nixos-tests) (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests)) - and/or [package tests](https://nixos.org/manual/nixpkgs/unstable/#sec-package-tests) - or, for functions and "core" functionality, tests in [lib/tests](https://github.com/NixOS/nixpkgs/blob/master/lib/tests) or [pkgs/test](https://github.com/NixOS/nixpkgs/blob/master/pkgs/test) - made sure NixOS tests are [linked](https://nixos.org/manual/nixpkgs/unstable/#ssec-nixos-tests-linking) to the relevant packages - [ ] Tested compilation of all packages that depend on this change using `nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"`. Note: all changes have to be committed, also see [nixpkgs-review usage](https://github.com/Mic92/nixpkgs-review#usage) - [ ] Tested basic functionality of all binary files (usually in `./result/bin/`) - [23.05 Release Notes (or backporting 22.11 Release notes)](https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md#generating-2305-release-notes) - [ ] (Package updates) Added a release notes entry if the change is major or breaking - [ ] (Module updates) Added a release notes entry if the change is significant - [ ] (Module addition) Added a release notes entry if adding a new NixOS module - [ ] (Release notes changes) Ran `nixos/doc/manual/md-to-db.sh` to update generated release notes - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md).

https://github.com/NixOS/nixpkgs/pull/218179

SamLukeYes · March 2, 2023, 12:36pm

https://github.com/NixOS/nixpkgs/pull/217069

ralismark · March 2, 2023, 1:18pm

https://github.com/NixOS/nixpkgs/pull/184782
https://github.com/NixOS/nixpkgs/pull/217863

github.com/NixOS/nixpkgs

services.dendrite: change ExecStartPre to a list

NixOS:master ← Francesco149:dendrite-prestart

opened 01:48PM - 21 Jun 22 UTC

Francesco149

+2 -2

###### Description of changes one might want to append more service pre-start… commands to put things such as certificates, keys, etc in the `/run/dendrite` directory. using `ExecStartPre` doesn't allow anything other than `lib.mkForce` . by using `preStart` instead, the user can merge extra commands into it ###### Things done - Built on platform(s) - [x] x86_64-linux - [ ] aarch64-linux - [ ] x86_64-darwin - [ ] aarch64-darwin - [ ] Tested compilation of all packages that depend on this change using `nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"`. Note: all changes have to be committed, also see [nixpkgs-review usage](https://github.com/Mic92/nixpkgs-review#usage) - **couldn't test this because it complains about nixos-install-tools being blacklisted** - [x] Tested basic functionality of all binary files (usually in `./result/bin/`)

https://github.com/NixOS/nixpkgs/pull/189490
https://github.com/NixOS/nixpkgs/pull/190261

illustris · March 2, 2023, 3:42pm

https://github.com/NixOS/nixpkgs/pull/215835

dennajort · March 2, 2023, 8:03pm

Ready to merge, reviewed and commit history fixed.

github.com/NixOS/nixpkgs

gimme-aws-creds: init at 2.5.0

NixOS:master ← jbgosselin:gimme-aws-creds-2.4.4

opened 07:39PM - 17 Dec 22 UTC

jbgosselin

+330 -0

###### Description of changes  - Add python application `gimme-aws-creds` https://github.com/Nike-Inc/gimme-aws-creds - Add python library `okta` https://github.com/okta/okta-sdk-python - Add python library `ctap-keyring-device` https://github.com/dany74q/ctap-keyring-device with patch for missing `pyobjc` - Add python library `pytest-recording` https://github.com/kiwicom/pytest-recording ###### Things done - Built on platform(s) - [x] x86_64-linux - [ ] aarch64-linux - [x] x86_64-darwin - [ ] aarch64-darwin - [x] For non-Linux: Is `sandbox = true` set in `nix.conf`? (See [Nix manual](https://nixos.org/manual/nix/stable/command-ref/conf-file.html)) - [ ] Tested, as applicable: - [NixOS test(s)](https://nixos.org/manual/nixos/unstable/index.html#sec-nixos-tests) (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests)) - and/or [package tests](https://nixos.org/manual/nixpkgs/unstable/#sec-package-tests) - or, for functions and "core" functionality, tests in [lib/tests](https://github.com/NixOS/nixpkgs/blob/master/lib/tests) or [pkgs/test](https://github.com/NixOS/nixpkgs/blob/master/pkgs/test) - made sure NixOS tests are [linked](https://nixos.org/manual/nixpkgs/unstable/#ssec-nixos-tests-linking) to the relevant packages - [ ] Tested compilation of all packages that depend on this change using `nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"`. Note: all changes have to be committed, also see [nixpkgs-review usage](https://github.com/Mic92/nixpkgs-review#usage) - [x] Tested basic functionality of all binary files (usually in `./result/bin/`) - [23.05 Release Notes (or backporting 22.11 Release notes)](https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md#generating-2305-release-notes) - [ ] (Package updates) Added a release notes entry if the change is major or breaking - [ ] (Module updates) Added a release notes entry if the change is significant - [ ] (Module addition) Added a release notes entry if adding a new NixOS module - [ ] (Release notes changes) Ran `nixos/doc/manual/md-to-db.sh` to update generated release notes - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md).

penalty1083 · March 8, 2023, 8:22am

github.com/NixOS/nixpkgs

geph: init at 4.7.8

NixOS:master ← penalty1083:geph

opened 08:13AM - 19 Dec 22 UTC

penalty1083

+3788 -0

###### Description of changes Closes https://github.com/NixOS/nixpkgs/pull/1693…26  ###### Things done - Built on platform(s) - [x] x86_64-linux - [ ] aarch64-linux - [ ] x86_64-darwin - [ ] aarch64-darwin - [ ] For non-Linux: Is `sandbox = true` set in `nix.conf`? (See [Nix manual](https://nixos.org/manual/nix/stable/command-ref/conf-file.html)) - [ ] Tested, as applicable: - [NixOS test(s)](https://nixos.org/manual/nixos/unstable/index.html#sec-nixos-tests) (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests)) - and/or [package tests](https://nixos.org/manual/nixpkgs/unstable/#sec-package-tests) - or, for functions and "core" functionality, tests in [lib/tests](https://github.com/NixOS/nixpkgs/blob/master/lib/tests) or [pkgs/test](https://github.com/NixOS/nixpkgs/blob/master/pkgs/test) - made sure NixOS tests are [linked](https://nixos.org/manual/nixpkgs/unstable/#ssec-nixos-tests-linking) to the relevant packages - [ ] Tested compilation of all packages that depend on this change using `nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"`. Note: all changes have to be committed, also see [nixpkgs-review usage](https://github.com/Mic92/nixpkgs-review#usage) - [ ] Tested basic functionality of all binary files (usually in `./result/bin/`) - [23.05 Release Notes (or backporting 22.11 Release notes)](https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md#generating-2305-release-notes) - [ ] (Package updates) Added a release notes entry if the change is major or breaking - [ ] (Module updates) Added a release notes entry if the change is significant - [ ] (Module addition) Added a release notes entry if adding a new NixOS module - [ ] (Release notes changes) Ran `nixos/doc/manual/md-to-db.sh` to update generated release notes - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md).  Ping author and reviewers in https://github.com/NixOS/nixpkgs/pull/169326 @jslll135 @NickCao @SuperSandro2000 @alienzj

All problems fixed and improved a lot since the first commit.