it got another review, can it get merged now?
https://github.com/NixOS/nixpkgs/pull/75670
1 Like
Aww, wish you didn’t have to beg for a merge. Got that one for you.
1 Like
Samae
February 10, 2020, 5:19pm
96
tokudan
February 10, 2020, 6:23pm
97
Enteee
February 13, 2020, 7:14am
99
Enteee
February 16, 2020, 9:54am
100
1 Like
clkamp
February 19, 2020, 2:00pm
102
Enteee
February 22, 2020, 10:21pm
103
This was already reviewed by someone else and just needs to be merged
https://github.com/NixOS/nixpkgs/pull/80853
Also reviewed by someone else and ready to go:
https://github.com/NixOS/nixpkgs/pull/80539
thmzlt
March 2, 2020, 1:38pm
106
Open PR (already reviewed) for the hobbes programming environment:
https://github.com/NixOS/nixpkgs/pull/79699
I don’t have merge permissions, but left an additional comment (all dependencies are in nativeBuildInputs, even non-built-time dependencies).
cole-h
March 2, 2020, 6:00pm
108
Already reviewed by somebody else, just needs to be merged:
https://github.com/NixOS/nixpkgs/pull/81344
Thanks!
thmzlt
March 5, 2020, 12:43pm
109
Addressed your comments on the PR.
Shou
March 8, 2020, 12:14am
110
These two PRs of mine have been reviewed and sitting around for a while now – can probably be merged
NixOS:master ← Shou:init-obinskit
opened 08:57PM - 16 Oct 19 UTC
###### Motivation for this change
This is the configuration software for the … enthusiast Anne Pro mechanical keyboard, used to update the firmware, change keyboard settings, clear Bluetooth connections from the device, set up backlighting colours, and so forth. I'm an owner of one and don't think I'm alone so I thought it'd be convenient to have this packaged. [They have an official Github](https://github.com/obinslab), but the software is proprietary to my knowledge (no license provided).
I've tested that the software works with my own Anne Pro II.
###### Things done
- [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
- Built on platform(s)
- [x] NixOS
- [ ] macOS
- [ ] other Linux distributions
- [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
- [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"`
- [x] Tested execution of all binary files (usually in `./result/bin/`)
- [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
- [ ] Ensured that relevant documentation is up to date
- [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).
NixOS:master ← Shou:init-mkchromecast
opened 05:49PM - 07 Mar 19 UTC
###### Motivation for this change
###### Things done
- [x] Tested us… ing sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
- Built on platform(s)
- [ ] NixOS
- [ ] macOS
- [x] other Linux distributions
- [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
- [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
- [x] Tested execution of all binary files (usually in `./result/bin/`)
- [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
- [ ] Assured whether relevant documentation is up to date
- [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).
---
Merge: ripcord: init at 0.4.23 by bqv · Pull Request #80402 · NixOS/nixpkgs · GitHub
I tested many of the features that the application has and it all seems to work great!
jonringer has already accepted this PR but worldofpeace hasn’t re-reviewed the latest changes. All their requested changes have been applied however so I think it should be fine.
Thank you all for your hard work!
clkamp
March 10, 2020, 8:51am
112
palo
March 11, 2020, 6:09am
113
This pull request is reviewd for quite some time.https://github.com/NixOS/nixpkgs/pull/72160