PRs already reviewed

Blackvoxel, a 3D sandbox game focused on automation
Rather simple mkDerivation, I’m just unsure if the desktop item works properly.
https://github.com/NixOS/nixpkgs/pull/242445

Xash3D
A game engine reimplemention GoldSrc. mkDerivation stuff, rather convoluted. It’s all proprietary games, so you need proprietary assets to run it. You can still build it without assets though.
It has been approved by one person and I haven’t seen any rebuttal since a while.
https://github.com/NixOS/nixpkgs/pull/238392

fallout-ce
mkDerivation, one person approved it (me). Needs assets to run but you can still build it without assets.
https://github.com/NixOS/nixpkgs/pull/239450

wipeout-rewrite
Another proprietary games which needs assets to run. That one is stalling hard. It’s been approved by one person already. I’ve also left one small remark but it should not stop this from being merged.
https://github.com/NixOS/nixpkgs/pull/248915

update to sm64ex, one approval from me, there’s still an open question about whether the commits are properly organized but otherwise it works.
https://github.com/NixOS/nixpkgs/pull/247227

erdnaxe · September 10, 2023, 9:12am

github.com/NixOS/nixpkgs

nixos/galene: do not restrict AF_NETLINK

NixOS:master ← erdnaxe:galene-fix

opened 11:47AM - 18 Aug 23 UTC

erdnaxe

+1 -1

## Description of changes Built-in TURN server requires AF_NETLINK address fa…mily. This fixes the following errors: ``` 2023/08/18 13:36:01 TURN: route ip+net: netlinkrib: address family not supported by protocol 2023/08/18 13:36:01 Relay test failed: failed to create network: route ip+net: netlinkrib: address family not supported by protocol 2023/08/18 13:36:01 Perhaps you didn't configure a TURN server? 2023/08/18 13:36:49 gotOffer: failed to create network: route ip+net: netlinkrib: address family not supported by protocol ``` ## Things done - Built on platform(s) - [ ] x86_64-linux - [ ] aarch64-linux - [ ] x86_64-darwin - [ ] aarch64-darwin - [ ] For non-Linux: Is `sandbox = true` set in `nix.conf`? (See [Nix manual](https://nixos.org/manual/nix/stable/command-ref/conf-file.html)) - [X] Tested, as applicable: - [NixOS test(s)](https://nixos.org/manual/nixos/unstable/index.html#sec-nixos-tests) (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests)) - and/or [package tests](https://nixos.org/manual/nixpkgs/unstable/#sec-package-tests) - or, for functions and "core" functionality, tests in [lib/tests](https://github.com/NixOS/nixpkgs/blob/master/lib/tests) or [pkgs/test](https://github.com/NixOS/nixpkgs/blob/master/pkgs/test) - made sure NixOS tests are [linked](https://nixos.org/manual/nixpkgs/unstable/#ssec-nixos-tests-linking) to the relevant packages - [ ] Tested compilation of all packages that depend on this change using `nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"`. Note: all changes have to be committed, also see [nixpkgs-review usage](https://github.com/Mic92/nixpkgs-review#usage) - [X] Tested basic functionality of all binary files (usually in `./result/bin/`) - [23.11 Release Notes](https://github.com/NixOS/nixpkgs/blob/master/nixos/doc/manual/release-notes/rl-2311.section.md) (or backporting [23.05 Release notes](https://github.com/NixOS/nixpkgs/blob/master/nixos/doc/manual/release-notes/rl-2305.section.md)) - [ ] (Package updates) Added a release notes entry if the change is major or breaking - [ ] (Module updates) Added a release notes entry if the change is significant - [ ] (Module addition) Added a release notes entry if adding a new NixOS module - [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md).

OPNA2608 · September 10, 2023, 11:49am

Reviewed, but I added some stuff myself so a second opinion wouldn’t hurt either.

github.com/NixOS/nixpkgs

coolercontrol: init at 1.1.0

NixOS:master ← codifryed:coolercontrol-0.17.0

opened 09:04PM - 13 Aug 23 UTC

codifryed

+4903 -0

## Description of changes  New package: CoolerControl is a program which controls cooling devices such as AIO coolers and fans under Linux. https://gitlab.com/coolercontrol/coolercontrol This package has 2 systemd services, a PySide6 GUI, and is written in both Rust and Python. ## Things done - Built on platform(s) - [x] x86_64-linux - [ ] aarch64-linux - [ ] x86_64-darwin - [ ] aarch64-darwin - [ ] For non-Linux: Is `sandbox = true` set in `nix.conf`? (See [Nix manual](https://nixos.org/manual/nix/stable/command-ref/conf-file.html)) - [ ] Tested, as applicable: - [NixOS test(s)](https://nixos.org/manual/nixos/unstable/index.html#sec-nixos-tests) (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests)) - and/or [package tests](https://nixos.org/manual/nixpkgs/unstable/#sec-package-tests) - or, for functions and "core" functionality, tests in [lib/tests](https://github.com/NixOS/nixpkgs/blob/master/lib/tests) or [pkgs/test](https://github.com/NixOS/nixpkgs/blob/master/pkgs/test) - made sure NixOS tests are [linked](https://nixos.org/manual/nixpkgs/unstable/#ssec-nixos-tests-linking) to the relevant packages - [x] Tested compilation of all packages that depend on this change using `nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"`. Note: all changes have to be committed, also see [nixpkgs-review usage](https://github.com/Mic92/nixpkgs-review#usage) - [x] Tested basic functionality of all binary files (usually in `./result/bin/`) - [23.11 Release Notes](https://github.com/NixOS/nixpkgs/blob/master/nixos/doc/manual/release-notes/rl-2311.section.md) (or backporting [23.05 Release notes](https://github.com/NixOS/nixpkgs/blob/master/nixos/doc/manual/release-notes/rl-2305.section.md)) - [ ] (Package updates) Added a release notes entry if the change is major or breaking - [ ] (Module updates) Added a release notes entry if the change is significant - [ ] (Module addition) Added a release notes entry if adding a new NixOS module - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md).