PRs already reviewed

misuzu · January 25, 2024, 9:11am

https://github.com/NixOS/nixpkgs/pull/246055

christoph-heiss · January 25, 2024, 3:50pm

Already reviewed, should be good to go.

https://github.com/NixOS/nixpkgs/pull/276541

deepfire · January 25, 2024, 5:19pm

https://github.com/NixOS/nixpkgs/pull/281894

deepfire · January 25, 2024, 5:20pm

https://github.com/NixOS/nixpkgs/pull/281895

deepfire · January 25, 2024, 5:20pm

https://github.com/NixOS/nixpkgs/pull/281880

panicgh · January 26, 2024, 6:37am

https://github.com/NixOS/nixpkgs/pull/259395

Irene · January 26, 2024, 6:53am

I believe that light: support brightness control keys by jluttine · Pull Request #60804 · NixOS/nixpkgs · GitHub should be merged

It’s an obvious good feature, it follows an existing pattern used for audio, it’s independent of desktop environment, and others have tested and found that it works for them.

Also it seems like a kind of contribution that we should be encouraging and not making overly difficult.

chvp · January 26, 2024, 11:43am

https://github.com/NixOS/nixpkgs/pull/283799

onemoresuza · January 26, 2024, 11:52am

Approved by package maintainer.
https://github.com/NixOS/nixpkgs/pull/283940#issue-2101717549

snow40479 · January 26, 2024, 12:29pm

Already reviewed, ready for merge.

https://github.com/NixOS/nixpkgs/pull/277391

kiara · January 27, 2024, 9:25pm

these browser packages seem good to merge as per nix-review + actually trying:

mercury-browser: init at 115.4.0 by redxtech · Pull Request #261805 · NixOS/nixpkgs · GitHub
thorium-browser: init at 120.0.6099.235 by rgri · Pull Request #284085 · NixOS/nixpkgs · GitHub

kiara · January 28, 2024, 12:52pm

fix ready for merge: wezterm: 20230712-072601-f4abf8fd -> 20240127-113634-bbcac864 by iynaix · Pull Request #284377 · NixOS/nixpkgs · GitHub

Ambroisie · January 28, 2024, 2:09pm

https://github.com/NixOS/nixpkgs/pull/284109
https://github.com/NixOS/nixpkgs/pull/276547

sikmir · January 28, 2024, 3:39pm

https://github.com/NixOS/nixpkgs/pull/282375

panicgh · January 28, 2024, 11:03pm

Doesn’t actually change the package, just cleans-up an outdated source pinning.

https://github.com/NixOS/nixpkgs/pull/282446

lucasbergman · January 29, 2024, 12:55pm

reviewed and approved: new package moneydance: moneydance: init at 2023.3_5064 by lucasbergman · Pull Request #283860 · NixOS/nixpkgs · GitHub

Greizgh · January 30, 2024, 12:32pm

Fixing seafile server:
https://github.com/NixOS/nixpkgs/pull/249523

liff · January 31, 2024, 10:09pm

I reviewed this new package a while ago:

https://github.com/NixOS/nixpkgs/pull/277811

AndersonTorres · February 2, 2024, 1:28pm

github.com/NixOS/nixpkgs

mov-cli: update

NixOS:master ← atorres1985-contrib:mov-cli

opened 05:57PM - 28 Jan 24 UTC

AndersonTorres

+64 -42

## Description of changes  Triggered by https://github.com/NixOS/nixpkgs/pull/284550 Waiting for https://github.com/NixOS/nixpkgs/pull/270691 ## Things done - Built on platform(s) - [x] x86_64-linux - [ ] aarch64-linux - [ ] x86_64-darwin - [ ] aarch64-darwin - For non-Linux: Is sandboxing enabled in `nix.conf`? (See [Nix manual](https://nixos.org/manual/nix/stable/command-ref/conf-file.html)) - [ ] `sandbox = relaxed` - [x] `sandbox = true` - [ ] Tested, as applicable: - [NixOS test(s)](https://nixos.org/manual/nixos/unstable/index.html#sec-nixos-tests) (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests)) - and/or [package tests](https://nixos.org/manual/nixpkgs/unstable/#sec-package-tests) - or, for functions and "core" functionality, tests in [lib/tests](https://github.com/NixOS/nixpkgs/blob/master/lib/tests) or [pkgs/test](https://github.com/NixOS/nixpkgs/blob/master/pkgs/test) - made sure NixOS tests are [linked](https://nixos.org/manual/nixpkgs/unstable/#ssec-nixos-tests-linking) to the relevant packages - [ ] Tested compilation of all packages that depend on this change using `nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"`. Note: all changes have to be committed, also see [nixpkgs-review usage](https://github.com/Mic92/nixpkgs-review#usage) - [ ] Tested basic functionality of all binary files (usually in `./result/bin/`) - [24.05 Release Notes](https://github.com/NixOS/nixpkgs/blob/master/nixos/doc/manual/release-notes/rl-2405.section.md) (or backporting [23.05](https://github.com/NixOS/nixpkgs/blob/master/nixos/doc/manual/release-notes/rl-2305.section.md) and [23.11](https://github.com/NixOS/nixpkgs/blob/master/nixos/doc/manual/release-notes/rl-2311.section.md) Release notes) - [ ] (Package updates) Added a release notes entry if the change is major or breaking - [ ] (Module updates) Added a release notes entry if the change is significant - [ ] (Module addition) Added a release notes entry if adding a new NixOS module - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md).  --- Add a :+1: [reaction] to [pull requests you find important]. [reaction]: https://github.blog/2016-03-10-add-reactions-to-pull-requests-issues-and-comments/ [pull requests you find important]: https://github.com/NixOS/nixpkgs/pulls?q=is%3Aopen+sort%3Areactions-%2B1-desc

github.com/NixOS/nixpkgs

nestopia-ue: 1.47 -> 1.52.0

NixOS:master ← atorres1985-contrib:nestopia-ue

opened 08:37PM - 24 Jan 24 UTC

AndersonTorres

+79 -186

## Description of changes  ## Things done - Built on platform(s) - [ ] x86_64-linux - [ ] aarch64-linux - [ ] x86_64-darwin - [ ] aarch64-darwin - For non-Linux: Is sandboxing enabled in `nix.conf`? (See [Nix manual](https://nixos.org/manual/nix/stable/command-ref/conf-file.html)) - [ ] `sandbox = relaxed` - [ ] `sandbox = true` - [ ] Tested, as applicable: - [NixOS test(s)](https://nixos.org/manual/nixos/unstable/index.html#sec-nixos-tests) (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests)) - and/or [package tests](https://nixos.org/manual/nixpkgs/unstable/#sec-package-tests) - or, for functions and "core" functionality, tests in [lib/tests](https://github.com/NixOS/nixpkgs/blob/master/lib/tests) or [pkgs/test](https://github.com/NixOS/nixpkgs/blob/master/pkgs/test) - made sure NixOS tests are [linked](https://nixos.org/manual/nixpkgs/unstable/#ssec-nixos-tests-linking) to the relevant packages - [ ] Tested compilation of all packages that depend on this change using `nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"`. Note: all changes have to be committed, also see [nixpkgs-review usage](https://github.com/Mic92/nixpkgs-review#usage) - [ ] Tested basic functionality of all binary files (usually in `./result/bin/`) - [24.05 Release Notes](https://github.com/NixOS/nixpkgs/blob/master/nixos/doc/manual/release-notes/rl-2405.section.md) (or backporting [23.05](https://github.com/NixOS/nixpkgs/blob/master/nixos/doc/manual/release-notes/rl-2305.section.md) and [23.11](https://github.com/NixOS/nixpkgs/blob/master/nixos/doc/manual/release-notes/rl-2311.section.md) Release notes) - [ ] (Package updates) Added a release notes entry if the change is major or breaking - [ ] (Module updates) Added a release notes entry if the change is significant - [ ] (Module addition) Added a release notes entry if adding a new NixOS module - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md).  --- Add a :+1: [reaction] to [pull requests you find important]. [reaction]: https://github.blog/2016-03-10-add-reactions-to-pull-requests-issues-and-comments/ [pull requests you find important]: https://github.com/NixOS/nixpkgs/pulls?q=is%3Aopen+sort%3Areactions-%2B1-desc

siddharthdhakane · February 2, 2024, 2:08pm

github.com/NixOS/nixpkgs

python311Packages.nameko: init at 2.4.1

NixOS:master ← siddharthdhakane:nameko

opened 09:20AM - 22 Jan 24 UTC

siddharthdhakane

+79 -0

## Description of changes  ## Things done - Built on platform(s) - [x] x86_64-linux - [ ] aarch64-linux - [ ] x86_64-darwin - [ ] aarch64-darwin - For non-Linux: Is sandboxing enabled in `nix.conf`? (See [Nix manual](https://nixos.org/manual/nix/stable/command-ref/conf-file.html)) - [ ] `sandbox = relaxed` - [ ] `sandbox = true` - [ ] Tested, as applicable: - [NixOS test(s)](https://nixos.org/manual/nixos/unstable/index.html#sec-nixos-tests) (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests)) - and/or [package tests](https://nixos.org/manual/nixpkgs/unstable/#sec-package-tests) - or, for functions and "core" functionality, tests in [lib/tests](https://github.com/NixOS/nixpkgs/blob/master/lib/tests) or [pkgs/test](https://github.com/NixOS/nixpkgs/blob/master/pkgs/test) - made sure NixOS tests are [linked](https://nixos.org/manual/nixpkgs/unstable/#ssec-nixos-tests-linking) to the relevant packages - [ ] Tested compilation of all packages that depend on this change using `nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"`. Note: all changes have to be committed, also see [nixpkgs-review usage](https://github.com/Mic92/nixpkgs-review#usage) - [x] Tested basic functionality of all binary files (usually in `./result/bin/`) - [24.05 Release Notes](https://github.com/NixOS/nixpkgs/blob/master/nixos/doc/manual/release-notes/rl-2405.section.md) (or backporting [23.05](https://github.com/NixOS/nixpkgs/blob/master/nixos/doc/manual/release-notes/rl-2305.section.md) and [23.11](https://github.com/NixOS/nixpkgs/blob/master/nixos/doc/manual/release-notes/rl-2311.section.md) Release notes) - [ ] (Package updates) Added a release notes entry if the change is major or breaking - [ ] (Module updates) Added a release notes entry if the change is significant - [ ] (Module addition) Added a release notes entry if adding a new NixOS module - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md).  --- Add a :+1: [reaction] to [pull requests you find important]. [reaction]: https://github.blog/2016-03-10-add-reactions-to-pull-requests-issues-and-comments/ [pull requests you find important]: https://github.com/NixOS/nixpkgs/pulls?q=is%3Aopen+sort%3Areactions-%2B1-desc