PRs already reviewed

lelgenio · March 14, 2024, 12:09pm

krita: wrap with plugins, krita-plugin-gmic init at 3.2.4.1

NixOS:master ← lelgenio:krita-plugin-gmic-package

opened 04:19AM - 31 Jan 24 UTC

## Description of changes - Renamed `krita` to `krita-unwrapped` - Created a… wrapper `krita` to load plugins not included in `krita-unwrapped` - Added the `krita-plugin-gmic` package, setting it as a default plugin Fixes: #163645 I decided on setting the wrapped version with gmic to be the true `krita` because it is included in the official Appimage. <details><summary>I tried using gmic from nixpkgs, but it was incompatible.</summary> ```nix (gmic.overrideAttrs { version = "3.2.4"; # The version required by the plugin }) ``` ```sh $ ./result/bin/krita ... *** stack smashing detected ***: terminated Magick: abort due to signal 6 (SIGABRT) "Abort"... ``` ``` #0 0x00007f52634a402c __pthread_kill_implementation (libc.so.6 + 0x8d02c) #1 0x00007f5263454e06 raise (libc.so.6 + 0x3de06) #2 0x00007f526343d97f abort (libc.so.6 + 0x2697f) #3 0x00007f51334ba437 MagickPanicSignalHandler (libGraphicsMagick.so.3 + 0xba437) #4 0x00007f5263454eb0 __restore_rt (libc.so.6 + 0x3deb0) #5 0x00007f52634a402c __pthread_kill_implementation (libc.so.6 + 0x8d02c) #6 0x00007f5263454e06 raise (libc.so.6 + 0x3de06) #7 0x00007f526343d8f5 abort (libc.so.6 + 0x268f5) #8 0x00007f526343e7a1 __libc_message.cold (libc.so.6 + 0x277a1) #9 0x00007f52635330c9 __fortify_fail (libc.so.6 + 0x11c0c9) #10 0x00007f5263534374 __stack_chk_fail (libc.so.6 + 0x11d374) #11 0x00007f5150354861 _ZN6GmicQt12FilterThread3runEv (krita_gmic_qt.so + 0x154861) #12 0x00007f5263ae386c _ZN14QThreadPrivate5startEPv (libQt5Core.so.5 + 0xe386c) #13 0x00007f52634a2333 start_thread (libc.so.6 + 0x8b333) #14 0x00007f5263524efc __clone3 (libc.so.6 + 0x10defc) ``` </details> ## Things done - Built on platform(s) - [x] x86_64-linux - [ ] aarch64-linux - [ ] x86_64-darwin - [ ] aarch64-darwin - For non-Linux: Is sandboxing enabled in `nix.conf`? (See [Nix manual](https://nixos.org/manual/nix/stable/command-ref/conf-file.html)) - [ ] `sandbox = relaxed` - [ ] `sandbox = true` - [ ] Tested, as applicable: - [NixOS test(s)](https://nixos.org/manual/nixos/unstable/index.html#sec-nixos-tests) (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests)) - and/or [package tests](https://nixos.org/manual/nixpkgs/unstable/#sec-package-tests) - or, for functions and "core" functionality, tests in [lib/tests](https://github.com/NixOS/nixpkgs/blob/master/lib/tests) or [pkgs/test](https://github.com/NixOS/nixpkgs/blob/master/pkgs/test) - made sure NixOS tests are [linked](https://nixos.org/manual/nixpkgs/unstable/#ssec-nixos-tests-linking) to the relevant packages - [x] Tested compilation of all packages that depend on this change using `nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"`. Note: all changes have to be committed, also see [nixpkgs-review usage](https://github.com/Mic92/nixpkgs-review#usage) - [x] Tested basic functionality of all binary files (usually in `./result/bin/`) - [24.05 Release Notes](https://github.com/NixOS/nixpkgs/blob/master/nixos/doc/manual/release-notes/rl-2405.section.md) (or backporting [23.05](https://github.com/NixOS/nixpkgs/blob/master/nixos/doc/manual/release-notes/rl-2305.section.md) and [23.11](https://github.com/NixOS/nixpkgs/blob/master/nixos/doc/manual/release-notes/rl-2311.section.md) Release notes) - [ ] (Package updates) Added a release notes entry if the change is major or breaking - [ ] (Module updates) Added a release notes entry if the change is significant - [ ] (Module addition) Added a release notes entry if adding a new NixOS module - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md).  --- Result of `nixpkgs-review` run on x86_64-linux [1](https://github.com/Mic92/nixpkgs-review) <details> <summary>3 packages built:</summary> <ul> <li>krita</li> <li>krita-plugin-gmic</li> <li>krita-unwrapped</li> </ul> </details> --- Add a :+1: [reaction] to [pull requests you find important]. [reaction]: https://github.blog/2016-03-10-add-reactions-to-pull-requests-issues-and-comments/ [pull requests you find important]: https://github.com/NixOS/nixpkgs/pulls?q=is%3Aopen+sort%3Areactions-%2B1-desc

mattpolzin · March 14, 2024, 3:15pm

Approved by all package maintainers: