PRs ready for review _

Approved by two reviewers (including me):
https://github.com/NixOS/nixpkgs/pull/84261

1 Like

https://github.com/NixOS/nixpkgs/pull/85507

I’ve got an update to macvim that needs review. This update is a little special in that the current macvim derivation is broken as of Xcode 11.4 so it needs to restore compatibility in addition to the normal version update.

https://github.com/NixOS/nixpkgs/pull/85321

I’ve got an update that needs review / merging, lots (4) people have looked at it and multiple have signed off, but I think so far no one has signed off who can merge it.
https://github.com/NixOS/nixpkgs/pull/83253

For anyone that likes minimal window managers, here are two packages that will add to Nixpkgs bevy of cool window managers:

https://github.com/NixOS/nixpkgs/pull/85495

https://github.com/NixOS/nixpkgs/pull/85174

Can someone review please :slight_smile:

Repost but still waiting for a review:
https://github.com/NixOS/nixpkgs/pull/85507

This is done and waiting for review, should be an easy one.
https://github.com/NixOS/nixpkgs/pull/85028

I’ve got a couple of items waiting for review. These are reposts but it’s been a while.

This needs someone who cares about macOS. And I’d really like to get it in sooner than later because macvim is currently broken with Xcode 11.4.

https://github.com/NixOS/nixpkgs/pull/85321

This one got reviewed by @Profpatsch a month ago but nothing since then. It needs a re-review.

https://github.com/NixOS/nixpkgs/pull/83630

Lily Ballard via NixOS Discourse nixos1@discoursemail.com writes:

This one got reviewed by @Profpatsch a month ago but nothing since then. It needs a re-review.

installShellFiles: Enhance installShellCompletion by lilyball · Pull Request #83630 · NixOS/nixpkgs · GitHub

Yep, sorry, I still have it open and look at it once in a while, but
haven’t had time to think about the testing issue. I suggest we merge
and think about tests as a followup.

Some Robot Operating System (ROS) dependencies I’m working on upstreaming:
https://github.com/NixOS/nixpkgs/pull/85983

An Esperanto dictionary for the command line:

https://github.com/NixOS/nixpkgs/pull/85040

PR got comments from someone who successfully tested it, but so far no code review, yet.

I wonder whether me implementing this as three packages is the right approach:

  • package prevo-tools provides

    • the executable prevodb to pre-process the dictionary data
    • the executable prevo to query the dictionary (requiring the pre-processed data)

    They’re build from the same source code repo and have a relation similar to the one between updatedb and locate.

  • package prevo-data provides the pre-processed dictionary data (using prevodb from prevo-tools at build-time)

  • package prevo links the other two packages together, so that the prevo command will use the data from prevo-data by default. (Can be overridden by a command line option.)

I’ve been successfully using this feature daily for seven weeks.

https://github.com/NixOS/nixpkgs/pull/72354

Repost but still waiting for a review: :pray:

https://github.com/NixOS/nixpkgs/pull/85507

Another look at my simplification that will also make our ISO’s closer to being reproducible would be great!

https://github.com/NixOS/nixpkgs/pull/74174

I think this 3 are ready to be merged:

https://github.com/NixOS/nixpkgs/pull/86592
https://github.com/NixOS/nixpkgs/pull/80553
https://github.com/NixOS/nixpkgs/pull/85157

I fixed the RethinkDB build: https://rethinkdb.com/

https://github.com/NixOS/nixpkgs/pull/87828#

I’d appreciate any other opinions on this PR:

https://github.com/NixOS/nixpkgs/pull/87369

Could someone please take a look at
https://github.com/NixOS/nixpkgs/pull/81440
It’s stalled for a while; thanks!

https://github.com/NixOS/nixpkgs/pull/88616

I still need a review on the zenith aarch64 PR please :pray: