PRs ready for review [May 2019]

Lily Ballard via NixOS Discourse nixos1@discoursemail.com writes:

This one got reviewed by @Profpatsch a month ago but nothing since then. It needs a re-review.

https://github.com/NixOS/nixpkgs/pull/83630

Yep, sorry, I still have it open and look at it once in a while, but
haven’t had time to think about the testing issue. I suggest we merge
and think about tests as a followup.

Some Robot Operating System (ROS) dependencies I’m working on upstreaming:

An Esperanto dictionary for the command line:

PR got comments from someone who successfully tested it, but so far no code review, yet.

I wonder whether me implementing this as three packages is the right approach:

  • package prevo-tools provides

    • the executable prevodb to pre-process the dictionary data
    • the executable prevo to query the dictionary (requiring the pre-processed data)

    They’re build from the same source code repo and have a relation similar to the one between updatedb and locate.

  • package prevo-data provides the pre-processed dictionary data (using prevodb from prevo-tools at build-time)

  • package prevo links the other two packages together, so that the prevo command will use the data from prevo-data by default. (Can be overridden by a command line option.)

A Python electrophysiology package, the packaging of which is quite simple:

https://github.com/NixOS/nixpkgs/pull/85420

I’ve been successfully using this feature daily for seven weeks.

Repost but still waiting for a review: :pray:

From a month ago, a gemini+gopher+finger browser:

Another look at my simplification that will also make our ISO’s closer to being reproducible would be great!

I think this 3 are ready to be merged:



I fixed the RethinkDB build: https://rethinkdb.com/

I’d appreciate any other opinions on this PR:

Could someone please take a look at


It’s stalled for a while; thanks!

I still need a review on the zenith aarch64 PR please :pray:

I’d appreciate a review on go-neb, it can be used for relaying Prometheus alerts to Matrix.

1 Like

Need someone who can review node packages to take a look here please:

dstask - taskwarrior alternative :metal:

4 Likes

merge:

1 Like


This one’s been waiting for almost a year, I’d really like to get a critical look on this derivation to tell me whether it’s too over-engineered or not.


These are done and ready for review / merge.


Lastly this one’s just afew weeks old but it’s a security-relevant bump. I’ll open a backport PR to 20.03 once it’s merged.