I’ve also already got an approval from @rycee on this next one but I don’t know if that’s waiting for @Ericson2314 (who’s listed as a code owner of the pkgs/build-support/setup-hooks directory), or if they just wanted someone else to approve it too.
Mostly needs someone to go over the changes to the install-grub.pl script, the systemd-boot-builder.py changes I am more confident in. Perl is not really in my bailiwick. This one had already bitrotted a bit, and as there are other changes to boot stuff coming, I’d rather not end up maintaining it locally longer-term…
I have pr I submitted and have been using without issue for a while now. Basically it allows sound.mediaKeys to work with pulseaudio. Doesn’t seem like anyone else has had time to review it but it works just fine and hasn’t caused me any issues. Should be ready to merge. Hopefully someone can take a look.
I’ve got a really old review that was just waiting for someone to test. I’ve been using it for about half a year now though we think it may not work on Desktop environments so if anyone is using a window manager and could quickly check it that would be great.
This is a small but very nice modification of nixos-install that allows to install into an nspawn compatible container (test and documentation included in the PR!). I have already approved it but a second opinion would be very welcome. https://github.com/NixOS/nixpkgs/pull/67232
I have closed the PR, because it turned out to be easy to make a single generic derivation for both FreeOffice and SoftMaker Office, which I submitted in the following PR:
This PR sets a couple of kernel options to allow applications to see more power information on some machines. Concretely, it lets s-tui show power information, which is nice.
I’m not 100% sure what I’m doing with kernel options, but this mirrors what Arch does and seems to work!