PRs ready for review _

This PR sets a couple of kernel options to allow applications to see more power information on some machines. Concretely, it lets s-tui show power information, which is nice.

I’m not 100% sure what I’m doing with kernel options, but this mirrors what Arch does and seems to work!

1 Like

I would love to get a review for this
https://github.com/NixOS/nixpkgs/pull/67670

https://github.com/NixOS/nixpkgs/pull/69088

I have reviewed this pr and think it is pretty much ready for merge. Would be good to get a second pair of eyes on it

Xcode 11 is out so I’d really like to get the macvim Xcode 11 compatibility fix merged. I’ve been running it locally with no problems.

~~https://github.com/NixOS/nixpkgs/pull/68534~~

I’d appreciate if somebody could review this PR which packages the KDE configuration module for configuring wacom graphics tablets, (although I realise that exhaustively testing it requires a wacom tablet). @tilpner has already pointed out a few issues, which I’ve fixed, so I’m hoping that it might be ready now.
https://github.com/NixOS/nixpkgs/pull/68836

Two new NixOS modules.
Sympa, a mailing list manager:
https://github.com/NixOS/nixpkgs/pull/65397

MoinMoin, a wiki engine:
https://github.com/NixOS/nixpkgs/pull/68327

Especially interested in feedback from people who run these services if there are any!

Updates of two spaCy dependencies:

Basically version + hash bumps, plus the necessary version constraint relaxations necessary in spaCy itself.

I would like an additional review on this one, just to be safe:

Can someone have a look at this PR please? It’s a simple update of one of the packages I maintain.

Hello, I add two new packages

https://github.com/NixOS/nixpkgs/pull/70282

If you put the links on their own line then discourse will make them look nicer

I’m looking for any httpd users on NixOS to compare their httpd.conf file generated by this PR to what is currently generated by NixOS. I would also appreciate any review of the nix code in this PR as the httpd module code is overly complicated - a second and third pair of eyes looking at the changes in depth would be appreciated, even by people who aren’t familiar with httpd but have strong nix lang skills.

I’ve had a PR open for 2.5 months that rewrites stripHash

https://github.com/NixOS/nixpkgs/pull/66161

This fixes a bug wherein stripHash --foo doesn’t treat --foo as a filename, and also massively improves performance in the process. The only problem is I’m not willing to rebuild the world on my machine, so I haven’t built any packages with this change, only tested in isolation on all inputs I can think of. It is targeting staging though.

2 Likes

https://github.com/NixOS/nixpkgs/pull/69124

I have some:

That’s all folks.

Not my PR. I reviewed it but the 2 maintainers don’t seem to have the time right now and we could use some extra pairs of eyes and someone to merge it.

~~https://github.com/NixOS/nixpkgs/pull/69962~~

I’ve got a MacVim update

~~https://github.com/NixOS/nixpkgs/pull/71380~~

This has been sitting around for almost 2 weeks, long enough that I’ve actually just updated it for yet another MacVim version.

1 Like

https://github.com/NixOS/nixpkgs/pull/71083

This PR has been around for 19 days now without a single comment.
Every new test in nixpkgs means I have to touch this again to get it to merge so I would really appreciate a review soon-ish.

1 Like

My MacVim update (see previous comment) is still pending.

I’ve also got a cocoapods update that’s over a month old at this point.

~~https://github.com/NixOS/nixpkgs/pull/70417~~

https://github.com/NixOS/nixpkgs/pull/71226

This commit needs a review from an experienced Go build system reviewer.
The hash of the gomods keeps changing for ofBorg, sometimes even during the same build run (eg. OK for x64_86, not ok for Darwin).