Here is another one:
https://github.com/NixOS/nixpkgs/pull/57947
I’m seeking opinion, feedback, and review on these 2 with the ultimate goal of deprecating services.httpd.extraSubservices
and explicit usage of mod_php
within existing modules:
https://github.com/NixOS/nixpkgs/pull/57752
https://github.com/NixOS/nixpkgs/pull/62175
I’m seeking testing from any gitea
users, especially those who use the postgresql
database backend:
https://github.com/NixOS/nixpkgs/pull/61923
I’m seeking review and testing from any hydron
users:
https://github.com/NixOS/nixpkgs/pull/62050
https://github.com/NixOS/nixpkgs/pull/61348
My PR is not that old, but i would appreciate some review and testing from users that uses Nix without NixOS, and arm64 users to see if i by any chance broke qtcreator compilation.
Note that there is llvm dependancy now so compilation may take some extra time.
That one fixes an annoying printing bug by actually just moving a line in cups config files. I could possibly benefit from a review by someone with a bit of cups configuration knowledge, but hasn’t received one yet.
https://github.com/NixOS/nixpkgs/pull/59076
This one has been siting there for 2 months, it’s a minor fix to Conan expression:
This one’s only been sitting there for 9 days but it’s truly trivial, just some gemset updates for cocoapods
.
https://github.com/NixOS/nixpkgs/pull/61906
Edit: Merged. Thanks!
There are two pending reviews for nixpkgs from my side:
https://github.com/NixOS/nixpkgs/pull/60029
https://github.com/NixOS/nixpkgs/pull/61308
And an older one from NixOS/nix:
https://github.com/NixOS/nix/pull/2266
Not mine, but one I’m looking forward to, should bring a lot of azure support to NixOS. https://github.com/NixOS/nixpkgs/pull/60435
Has already been reviewed by two people, needs someone able to review for merging.
Merged! Thanks!
Looking for other opinions on whether these added options are valuable. I believe they are:
https://github.com/NixOS/nixpkgs/pull/41798
Another httpd subservice converted into a module:
It would be great to get these two commits merged if possible, neither are really old but both have approving reviews and I believe are ready to merge.
https://github.com/NixOS/nixpkgs/pull/62617
https://github.com/NixOS/nixpkgs/pull/62609
This one fixes a bug hasn’t seen any response in a few months:
Here’s a security fix for znc that’s waiting since yesterday: znc: 1.7.2 -> 1.7.3 Security, 19.03 by tokudan · Pull Request #63141 · NixOS/nixpkgs · GitHub
It’s just a cherry-pick from master into release-19.03.
I’ve got 2 PRs that haven’t gotten any response yet.
This one fixes bundlerApp
to actually do what the documentation says and provide the env
and wrappedRuby
attributes in passthru
:
https://github.com/NixOS/nixpkgs/pull/62971
This one updates the broken macvim
package to work again. It’s not pure (it relies on a few system-provided tools, including Xcode, and MacVim’s build process picks up the current OS as the deployment target) but the old package wasn’t pure either.
https://github.com/NixOS/nixpkgs/pull/62934
Edit: Merged, thanks!
I’d like some feedback as to whether my current approach is fine or whether there’s something better.
I.e. something that doesn’t duplicate the nix code from the original package but doesn’t have to build wine just for the fonts.
Thanks
I’ve got a couple of trivial PRs that have already had eyeballs on them but nobody’s merged them.