PRs ready for review _

moaxcp · October 7, 2019, 10:47am

Hello, I add two new packages

https://github.com/NixOS/nixpkgs/pull/70282

github.com/NixOS/nixpkgs

asciidoctorj init at 2.1.0

NixOS:master ← moaxcp:asciidoctorj

opened 10:09AM - 07 Oct 19 UTC

moaxcp

+38 -0

###### Motivation for this change Add asciidoctorj package ###### Things d…one - [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS) - Built on platform(s) - [x] NixOS - [ ] macOS - [ ] other Linux distributions - [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests)) - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"` - [x] Tested execution of all binary files (usually in `./result/bin/`) - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after) - [ ] Ensured that relevant documentation is up to date - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md). ###### Notify maintainers cc @

alexarice · October 7, 2019, 12:25pm

If you put the links on their own line then discourse will make them look nicer

aanderse · October 15, 2019, 8:59pm

I’m looking for any httpd users on NixOS to compare their httpd.conf file generated by this PR to what is currently generated by NixOS. I would also appreciate any review of the nix code in this PR as the httpd module code is overly complicated - a second and third pair of eyes looking at the changes in depth would be appreciated, even by people who aren’t familiar with httpd but have strong nix lang skills.

github.com/NixOS/nixpkgs

nixos/httpd: remove deprecated extraSubservices option

NixOS:master ← aanderse:httpd

opened 01:49AM - 13 Oct 19 UTC

aanderse

+24 -109

###### Motivation for this change Cleaning up the `httpd` module. I would ap…preciate the efforts of any `httpd` users who would run their configuration through this branch, compare the generated `httpd.conf` to their own, and then share the results. ###### Things done I have compared several `httpd` configuration files generated by this new build compared to what `19.09` builds and they are pretty much identical. - [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS) - Built on platform(s) - [x] NixOS - [ ] macOS - [ ] other Linux distributions - [x] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests)) - [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nix-review --run "nix-review wip"` - [ ] Tested execution of all binary files (usually in `./result/bin/`) - [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after) - [x] Ensured that relevant documentation is up to date - [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md). ###### Notify maintainers cc @

lilyball · October 19, 2019, 9:06pm

I’ve had a PR open for 2.5 months that rewrites stripHash

https://github.com/NixOS/nixpkgs/pull/66161

This fixes a bug wherein stripHash --foo doesn’t treat --foo as a filename, and also massively improves performance in the process. The only problem is I’m not willing to rebuild the world on my machine, so I haven’t built any packages with this change, only tested in isolation on all inputs I can think of. It is targeting staging though.

asbachb · October 20, 2019, 10:54pm

https://github.com/NixOS/nixpkgs/pull/69124

doronbehar · October 21, 2019, 10:24am

I have some:

~~https://github.com/NixOS/nixpkgs/pull/70441~~ - Seems pretty good to me, needs experience of someone with yarn2nix based packages.
~~https://github.com/NixOS/nixpkgs/pull/70372~~ - gaia init I’m satisfied but I’ve had some comments.
essentia: init at 2.1_beta5 by doronbehar · Pull Request #70389 · NixOS/nixpkgs · GitHub - essentia init - depends on gaia. Had some comments there too but might worth a 2nd opinion.
[WIP] beets: use new essentia package for absubmit plugin by doronbehar · Pull Request #70392 · NixOS/nixpkgs · GitHub - The ultimate goal of the 2 above.
~~https://github.com/NixOS/nixpkgs/pull/70509~~ snzip init - very simple and standard package.

That’s all folks.

bbigras · October 30, 2019, 4:47pm

Not my PR. I reviewed it but the 2 maintainers don’t seem to have the time right now and we could use some extra pairs of eyes and someone to merge it.

~~https://github.com/NixOS/nixpkgs/pull/69962~~

lilyball · October 30, 2019, 10:11pm

I’ve got a MacVim update

~~https://github.com/NixOS/nixpkgs/pull/71380~~

This has been sitting around for almost 2 weeks, long enough that I’ve actually just updated it for yet another MacVim version.

ckampka · November 1, 2019, 9:48am

https://github.com/NixOS/nixpkgs/pull/71083

This PR has been around for 19 days now without a single comment.
Every new test in nixpkgs means I have to touch this again to get it to merge so I would really appreciate a review soon-ish.

lilyball · November 6, 2019, 10:47pm

My MacVim update (see previous comment) is still pending.

I’ve also got a cocoapods update that’s over a month old at this point.

~~https://github.com/NixOS/nixpkgs/pull/70417~~

ckampka · November 7, 2019, 10:28am

https://github.com/NixOS/nixpkgs/pull/71226

This commit needs a review from an experienced Go build system reviewer.
The hash of the gomods keeps changing for ofBorg, sometimes even during the same build run (eg. OK for x64_86, not ok for Darwin).

danieldk · November 7, 2019, 11:48am

https://github.com/NixOS/nixpkgs/pull/70306

This PR has seen no activity since I submitted it a month ago. It’s really a simple change – it adds spaCy models for Norwegian and Lithuanian. What is mostly needed: test if it builds, test if the model loads.

cko · November 7, 2019, 11:26pm

https://github.com/NixOS/nixpkgs/pull/70941

Version update, metadata addition, etc. for hsqldb a small relational dabase management system.

cko · November 10, 2019, 8:37am

https://github.com/NixOS/nixpkgs/pull/70210

A version update waiting for reviews.

rnhmjoj · November 10, 2019, 10:23pm

It’s been a while since I submitted this: nixos: unify virtual console options by rnhmjoj · Pull Request #71473 · NixOS/nixpkgs · GitHub.
I’m trying to reorganize the options about virtual console and I’d like to hear some opinions.

marcus7070 · November 16, 2019, 1:44am

https://github.com/NixOS/nixpkgs/pull/66254
I’ve had this PR open for 3 months now. It’s my first PR for nixpkgs and there is a fair few changes in there. Anything I can do to make it easier to merge?

I’ve been using this branch as my main nixpkgs for 3 months now with no issues.

There is some interest in it so I think it’s worth merging; there were three other Nix users before me who tried to get it working, and I’ve got another Nix user who wants to use it now.

petabyteboy · November 22, 2019, 11:26am

I’ve got this one with an OfBorg failure I can not figure out:

~~https://github.com/NixOS/nixpkgs/pull/71468~~

bdesham · November 22, 2019, 11:53pm

I’ve got one that should be uncontroversial: a set of Ruby-based CLI applications for transcoding video. They essentially wrap Handbrake, FFmpeg, and a couple of other tools to provide sane defaults and a nicer interface overall.

https://github.com/NixOS/nixpkgs/pull/69102

ilikeavocadoes · November 25, 2019, 10:43am

This needs a re-review and is only a 3 line change:

https://github.com/NixOS/nixpkgs/pull/73615

pstch · November 26, 2019, 1:16am

https://github.com/NixOS/nixpkgs/pull/73902

Package options for LXC, LXD and ZFS in NixOS’s LXD module.