PRs ready for review _

A simple pr that add a package

https://github.com/NixOS/nixpkgs/pull/74775

~~wrap gitolite-shell to make with work with HTTP auth and nginx.
it includes my first nixos test.
https://github.com/NixOS/nixpkgs/pull/75005~~

This has been stuck for a while but I made a breakthrough and should be ready now.
https://github.com/NixOS/nixpkgs/pull/72368

~~sssd can’t load the “ad” module without this update:
https://github.com/NixOS/nixpkgs/pull/75167~~

Two months and counting now, would really apprechiate a review

https://github.com/NixOS/nixpkgs/pull/70526

Hi! Would appreciate a review: klayout: init at 0.26.2 by knedlsepp · Pull Request #73941 · NixOS/nixpkgs · GitHub

Easy-peasy
https://github.com/NixOS/nixpkgs/pull/75124

https://github.com/NixOS/nixpkgs/pull/70239

https://github.com/NixOS/nixpkgs/pull/76347
https://github.com/NixOS/nixpkgs/pull/76353

Can anyone review this please :cry: ?
https://github.com/NixOS/nixpkgs/pull/75124

In case somebody is interested in reviewing NixOS-changes:

Can anyone please review jetbrains.* 2019.2.* -> 2019.3 by kolaente · Pull Request #73879 · NixOS/nixpkgs · GitHub ?

I only ran the update script, it should be not much hassle to review.

1 Like

I’m already using the updated version of idea-ultimate locally and it’s running brilliantly :slight_smile:

@ktor I do too, now we just need to get this into master :slight_smile:

I have a positive review from a keybase package maintainer: kbfs, nixos/keybase, nixos/kbfs: fix KBFS, add enableRedirector option by tadfisher · Pull Request #75922 · NixOS/nixpkgs · GitHub

I spent some effort testing this simplification of the bootable ISO generation process, which also makes it more deterministic:

https://github.com/NixOS/nixpkgs/pull/74174

It works on all machines/media I found and people seem generally in favor of the change, but it is a bit scary so some more eyes on it would be helpful.

I’d appreciate it if someone would review these.

This needs a re-review:
https://github.com/NixOS/nixpkgs/pull/48740

This depends on the above PR:
https://github.com/NixOS/nixpkgs/pull/49413

Both have been working on my machine for over a year without issues.

https://github.com/NixOS/nixpkgs/pull/77597

A PR I’d like to get merged before the 20.03 code freeze:

https://github.com/NixOS/nixpkgs/pull/77347

I would be very thankful if someone could have a look at

https://github.com/NixOS/nixpkgs/pull/78573