PRs ready for review _

I would appreciate an extra pair of eyes on https://github.com/NixOS/nixpkgs/pull/63932 if anyone has the time.

I mentioned this a week ago but https://github.com/NixOS/nixpkgs/pull/63678 is a trivial PR that still hasn’t been merged.

PR 63371 has been languishing for a while now. A reviewer raised a question, and I answered it, but then… no response.

Edit: Merged now. Thank you @Infinisil :pray:

PR 64204, which is adding one Node package and updating all Node packages. Had an issue where by version of node2nix was old, which I fixed the same day. Has been sitting for just over two weeks now.

Seeking secondary review of anyone has a moment to spare please.

This thread is tagged as May. At what point do we create a new thread? And maybe we should pin the current “PRs ready for review” to the top so people can find it more easily.

Any keepassx users?

I’ve got a PR open for a setup script that allows you to declare manpages and shell completions in a declarative fashion, so you don’t have to remember where the darn things are supposed to be installed. This came out of this prior discussion.

Still have one open as part of an update. Noticed it was broken when reviewing an automated update.

While playing the triage game I found this PR which hasn’t been reviewed:

Any volunteers?

This PR for updating vcv-rack has been informally reviewed and might need a last look before merge. :slight_smile:

This PR has been informally reviewed and tested, might need a quick look and merge:

This PR could use some additional attention, it’s already been through some technical revisions:

It’s not really clear to me how long I should let my PRs sit before listing them here, but my trivial macvim update has been sitting for a week.

https://github.com/NixOS/nixpkgs/pull/65713

I’ve also already got an approval from @rycee on this next one but I don’t know if that’s waiting for @Ericson2314 (who’s listed as a code owner of the pkgs/build-support/setup-hooks directory), or if they just wanted someone else to approve it too.

We need someone with some basic nginx knowledge. This PR is pretty simple, but I’ve never used nginx so I just don’t have the context.

Would appreciate a second pair of eyes, or any domain specific experts:

This has been sitting for a while, and I still use this patch in other projects: https://github.com/NixOS/nixpkgs/pull/51588

I hope I’m not too late for the party, but I have a nice package init waiting:

Mostly needs someone to go over the changes to the install-grub.pl script, the systemd-boot-builder.py changes I am more confident in. Perl is not really in my bailiwick. This one had already bitrotted a bit, and as there are other changes to boot stuff coming, I’d rather not end up maintaining it locally longer-term…

I’m looking for review regarding some changes to the phpfpm module.