# PRs ready for review \_
**URL:** https://discourse.nixos.org/t/prs-ready-for-review/3032
**Category:** Development
**Created:** [May 25, 2019, 10:38pm UTC](https://discourse.nixos.org/t/prs-ready-for-review/3032 "2019-05-25T22:38:38Z")
**Posts on this page:** 1
**Showing post:** 3678
### Author:  [@luizirber](https://discourse.nixos.org/u/luizirber)
#### Post date: [March 23, 2024, 5:43pm UTC](https://discourse.nixos.org/t/prs-ready-for-review/3032/3678 "2024-03-23T17:43:33Z")
>
>
> \## Description of changes
>
> Diff: https://github.com/sourmash-bio/sourmash/comp…are/v4.8.4...v4.8.7
>
> Changelog: https://github.com/sourmash-bio/sourmash/releases/tag/v4.8.7
>
> \## Things done
>
>
>
> \- Built on platform(s)
> - \[x\] x86\_64-linux
> - \[\] aarch64-linux
> - \[x\] x86\_64-darwin
> - \[\] aarch64-darwin
> \- For non-Linux: Is sandboxing enabled in \`nix.conf\`? (See \[Nix manual\](https://nixos.org/manual/nix/stable/command-ref/conf-file.html))
> - \[\] \`sandbox = relaxed\`
> - \[x\] \`sandbox = true\`
> \- \[x\] Tested, as applicable:
> - \[NixOS test(s)\](https://nixos.org/manual/nixos/unstable/index.html#sec-nixos-tests) (look inside \[nixos/tests\](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
> - and/or \[package tests\](https://nixos.org/manual/nixpkgs/unstable/#sec-package-tests)
> - or, for functions and "core" functionality, tests in \[lib/tests\](https://github.com/NixOS/nixpkgs/blob/master/lib/tests) or \[pkgs/test\](https://github.com/NixOS/nixpkgs/blob/master/pkgs/test)
> - made sure NixOS tests are \[linked\](https://nixos.org/manual/nixpkgs/unstable/#ssec-nixos-tests-linking) to the relevant packages
> \- \[x\] Tested compilation of all packages that depend on this change using \`nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"\`. Note: all changes have to be committed, also see \[nixpkgs-review usage\](https://github.com/Mic92/nixpkgs-review#usage)
> \- \[x\] Tested basic functionality of all binary files (usually in \`./result/bin/\`)
> \- \[24.05 Release Notes\](https://github.com/NixOS/nixpkgs/blob/master/nixos/doc/manual/release-notes/rl-2405.section.md) (or backporting \[23.05\](https://github.com/NixOS/nixpkgs/blob/master/nixos/doc/manual/release-notes/rl-2305.section.md) and \[23.11\](https://github.com/NixOS/nixpkgs/blob/master/nixos/doc/manual/release-notes/rl-2311.section.md) Release notes)
> - \[\] (Package updates) Added a release notes entry if the change is major or breaking
> - \[\] (Module updates) Added a release notes entry if the change is significant
> - \[\] (Module addition) Added a release notes entry if adding a new NixOS module
> \- \[x\] Fits \[CONTRIBUTING.md\](https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md).
>
> \---
>
> Add a :+1: \[reaction\] to \[pull requests you find important\].
>
> \[reaction\]: https://github.blog/2016-03-10-add-reactions-to-pull-requests-issues-and-comments/
> \[pull requests you find important\]: https://github.com/NixOS/nixpkgs/pulls?q=is%3Aopen+sort%3Areactions-%2B1-desc
---
_[View the full topic](https://discourse.nixos.org/t/prs-ready-for-review/3032)._