PRs ready for review _

aionescu · November 5, 2025, 6:54pm

This PR packages the fingerprint driver for newer Dell laptops and updates the existing driver for older devices:

github.com/NixOS/nixpkgs

libfprint-2-tod1-broadcom: 5.12.018 -> 5.15.285-5.15.010.0; libfprint-2-tod1-broadcom-cv3plus: init at 6.3.299-6.3.040.0

master ← aionescu:libfprint-2-tod1-broadcom-cv3plus

opened 12:33AM - 02 Nov 25 UTC

aionescu

+133 -10

This PR does two things: * Updates the `libfprint-2-tod1-broadcom` fingerprin…t driver to the latest upstream version, also updating its source URL (since it changed recently). * Adds the `libfprint-2-tod1-broadcom-cv3plus` driver, which provides the same functionality, but for newer Dell devices. Notes for reviewers: * The new `-cv3plus` package uses the same `patchelf --rename-dynamic-symbols` technique as the existing package, just with a different path. I duplicated the `wrapper-lib` C code because `nixpkgs-vet` didn't let me share it between packages. It would probably be a good idea to abstract out this pattern, given that more packages than just these 2 are using it, but that would likely be a larger-scale endeavor. * I included both changes in one PR since the packages are related and their definitions are very similar. I'm also happy to split them into separate PRs. * The `-cv3plus` driver could instead be included as part of the base package, but I thought it's better to keep them separate as they are released & versioned independently. Closes #343133. Pinging @pitkling and @sunsetkookaburra for potential reviews (based on the discussion in the linked issue). Also, @pitkling, this PR is partly based on [your fork](https://github.com/pitkling/nixpkgs/tree/libfprint-2-tod1-broadcom-update). Would you like to be added as co-author (and/or co-maintainer of the new `-cv3plus` package)? ## Things done - Built on platform: - [x] x86_64-linux - [ ] aarch64-linux - [ ] x86_64-darwin - [ ] aarch64-darwin - Tested, as applicable: - [ ] [NixOS tests] in [nixos/tests]. - [ ] [Package tests] at `passthru.tests`. - [ ] Tests in [lib/tests] or [pkgs/test] for functions and "core" functionality. - [ ] Ran `nixpkgs-review` on this PR. See [nixpkgs-review usage]. - [x] Tested basic functionality of all binary files, usually in `./result/bin/`. - Nixpkgs Release Notes - [ ] Package update: when the change is major or breaking. - NixOS Release Notes - [ ] Module addition: when adding a new NixOS module. - [ ] Module update: when the change is significant. - [ ] Fits [CONTRIBUTING.md], [pkgs/README.md], [maintainers/README.md] and other READMEs. [NixOS tests]: https://nixos.org/manual/nixos/unstable/index.html#sec-nixos-tests [Package tests]: https://github.com/NixOS/nixpkgs/blob/master/pkgs/README.md#package-tests [nixpkgs-review usage]: https://github.com/Mic92/nixpkgs-review#usage [CONTRIBUTING.md]: https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md [lib/tests]: https://github.com/NixOS/nixpkgs/blob/master/lib/tests [maintainers/README.md]: https://github.com/NixOS/nixpkgs/blob/master/maintainers/README.md [nixos/tests]: https://github.com/NixOS/nixpkgs/blob/master/nixos/tests [pkgs/README.md]: https://github.com/NixOS/nixpkgs/blob/master/pkgs/README.md [pkgs/test]: https://github.com/NixOS/nixpkgs/blob/master/pkgs/test --- Add a :+1: [reaction] to [pull requests you find important]. [reaction]: https://github.blog/2016-03-10-add-reactions-to-pull-requests-issues-and-comments/ [pull requests you find important]: https://github.com/NixOS/nixpkgs/pulls?q=is%3Aopen+sort%3Areactions-%2B1-desc