PRs ready for review _

Two months and counting now, would really apprechiate a review

Hi! Would appreciate a review: https://github.com/NixOS/nixpkgs/pull/73941

Easy-peasy


Can anyone review this please :cry: ?

In case somebody is interested in reviewing NixOS-changes:

Can anyone please review https://github.com/NixOS/nixpkgs/pull/73879 ?

I only ran the update script, it should be not much hassle to review.

1 Like

I’m already using the updated version of idea-ultimate locally and it’s running brilliantly :slight_smile:

@ktor I do too, now we just need to get this into master :slight_smile:

I have a positive review from a keybase package maintainer: https://github.com/NixOS/nixpkgs/pull/75922

I spent some effort testing this simplification of the bootable ISO generation process, which also makes it more deterministic:

It works on all machines/media I found and people seem generally in favor of the change, but it is a bit scary so some more eyes on it would be helpful.

I’d appreciate it if someone would review these.

This needs a re-review:

This depends on the above PR:

Both have been working on my machine for over a year without issues.

New and simple package. Just installs some HTML and text files:

I would like to get more feedback on this attempt to package testing:

I plan to document it afterwards, so more people can write simple tests for packages.

A PR I’d like to get merged before the 20.03 code freeze:

I would be very thankful if someone could have a look at

I have got some PRs from November that seem to have been forgotten about.
https://github.com/NixOS/nixpkgs/pull/74711 Backports a fix to release-19.09. My changes have already been reviewed, but it has not been merged.
https://github.com/NixOS/nixpkgs/pull/74689 I fixed a nondeterministic build. I am looking for it to be reviewed specifically on how this problem should be handled. Should there be some way to specify that you a version that uses the AES-NI instructions.
https://github.com/NixOS/nixpkgs/pull/73547 Another backport to release-19.09 that fixes a broken build. This one has not been reviewed yet.