Removing a maintainer from package metadata

Development
1

I am co-maintainer of some packages in nixpkgs. Another maintainer is tstrobel, which I am failing to find on github. Can/Should him/her be safely removed from the maintainer list?

The packages are:

  • enlightenment.efl
  • enlightenment.enlightenment
  • enlightenment.terminology
  • enlightenment.econnman
1 Like
2

Well, if you are available to maintain these pieces, then he can be safely removed.

1 Like
3

interesting, no github entry.

nix-repl> lib.maintainers.tstrobel
{ email = "4ZKTUB6TEP74PYJOPWIR013S2AV29YUBW5F9ZH2F4D5UMJUJ6S@hash.domains"; name = "Thomas Strobel"; }
4

That user seems to maintain good a bunch of packages it seems:

$ git grep tstrobel | grep -v maintainer-list | wc -l
43
5

If anything, I can adopt them - the orphaned ones, to be precise.

There are 34 packages with him as maintainer:

pkgs/applications/misc/diffpdf/default.nix
pkgs/applications/misc/tpmmanager/default.nix
pkgs/applications/office/ib/controller/default.nix
pkgs/applications/office/ib/tws/default.nix
pkgs/applications/office/moneyplex/default.nix
pkgs/applications/virtualization/driver/win-pvdrivers/default.nix
pkgs/applications/virtualization/driver/win-qemu/default.nix
pkgs/applications/virtualization/driver/win-signed-gplpv-drivers/default.nix
pkgs/applications/virtualization/driver/win-spice/default.nix
pkgs/applications/virtualization/driver/win-virtio/default.nix
pkgs/applications/virtualization/qboot/default.nix
pkgs/applications/virtualization/seabios/default.nix
pkgs/build-support/templaterpm/default.nix
pkgs/development/libraries/gstreamer/vaapi/default.nix
pkgs/development/libraries/libHX/default.nix
pkgs/development/libraries/neardal/default.nix
pkgs/development/python-modules/snappergui/default.nix
pkgs/development/python-modules/toposort/default.nix
pkgs/misc/screensavers/xtrlock-pam/default.nix
pkgs/os-specific/linux/ima-evm-utils/default.nix
pkgs/os-specific/linux/miraclecast/default.nix
pkgs/os-specific/linux/pam_mount/default.nix
pkgs/servers/neard/default.nix
pkgs/servers/openxpki/default.nix
pkgs/servers/web-apps/restya-board/default.nix
pkgs/tools/X11/xpra/libfakeXinerama.nix
pkgs/tools/security/aide/default.nix
pkgs/tools/security/chaps/default.nix
pkgs/tools/security/omapd/default.nix
pkgs/tools/security/opencryptoki/default.nix
pkgs/tools/security/sbsigntool/default.nix
pkgs/tools/security/simple-tpm-pk11/default.nix
pkgs/tools/security/tpm-luks/default.nix
1 Like
6

It seems as if tstrobel is not the only non-GitHub user:

nix eval --impure --expr 'with import <nixpkgs> {}; builtins.toJSON lib.maintainers' | jq --raw-output . | jq --compact-output '.[] | select(.githubId | not)' | wc -l
42
1 Like
7

there are some contributors which prefer to not have a github account or leak their existing ones. Have you tried writing an email? I guess having a github account is not mandatory for maintaining a package and it doesn’t do any harm to have him in there?

2 Likes
8

Well, we aren’t “self-hosting” the code after all, and we don’t use github as a mere central repository. Github is integrated to our workflow.

9

I have git blamed the maintainers for some of the names in my list.

I found 2 commits on 5 examples, including tstrobel:

  • 220459858b34 “Sort and format”
  • f7da7fa0c3ab "Revert "Revert “Convert maintainer file entries to attributes, add gi…”

I haven’t tried going beyond those 2 commits, as my git-foo on the terminal isn’t good enough to see what happend before the last change with blame and the GitHub blame doesn’t even load for me, as GitHub errors out, as the request took to long…