Satisfaction survey from the new RFC 166 formatting?

Malix · June 1, 2025, 8:47pm

True.

Those would need to be merged first

github.com/NixOS/nix

Indented strings do not work with tabs

opened 11:41AM - 28 Jun 20 UTC

closed 08:31PM - 29 Jun 20 UTC

piegamesde

**Is your feature request related to a problem? Please describe.** The manual… says about indented strings: > This kind of string literal intelligently strips indentation from the start of each line. To be precise, it strips from each line a number of spaces equal to the minimal indentation of the string as a whole (disregarding the indentation of empty lines). This is exclusive to spaces and won't work on files indented using tabs. **Describe the solution you'd like** I'd like to have it work with tabs as well. **Describe alternatives you've considered** - Create some helper functionality to convert between tabs and spaces - Create some helper functionality to strip tabbed indented strings - Resign and use soft tabs **Additional context** I use tabs for indentation. Programming languages should not force me to use spaces for some features to work.

github.com/NixOS/nix

Tabs silently break indentation stripping

opened 02:22PM - 14 Feb 23 UTC

roberth

bug language breaking

**Describe the bug** Tabs are not supported in the indentation stripping pars…er. This is the right behavior in principle, but when a user does insert a tab, the behavior does not match their indentation. The right solution is to warn and let the user fix the problem. Supporting tabs is wrong, because tab width is undefined and will never be defined consistently. Adding a warning may make `'' ''` strings annoying for users who have to write strings with tabs at the start of lines, but their solution is already fragile, so they should move to explicit tabs (`"\t"`) or put the string in a separate file. **Steps To Reproduce** 1. Write a file with a `''` string indented with tabs or a mix of spaces and tabs. 2. Parsed string contains tab characters. **Expected behavior** Warn when the first tab is encountered in the indentation stripping logic. Suggest alternatives, for both cases: user wants tabs stripped, or (less likely, current behavior) user wants to keep tabs in their string. **`nix-env --version` output** **Additional context** Removing tabs from indented strings is a hash-changing breaking change. (edit: 2024-10) - see also https://github.com/NixOS/nix/pull/9971#issuecomment-1986903150 **Priorities** Add :+1: to [issues you find important](https://github.com/NixOS/nix/issues?q=is%3Aissue+is%3Aopen+sort%3Areactions-%2B1-desc).

github.com/NixOS/nix

Indented strings do not work with tabs

opened 08:24AM - 07 Oct 23 UTC

closed 07:10AM - 10 Oct 23 UTC

usagi-flow

bug

**Describe the bug** Indented strings do not work with tabs: The "smart inden…tation" as described in the [documentation](https://nixos.org/manual/nix/stable/language/values.html#type-string) does not work: > This kind of string literal intelligently strips indentation from the start of each line. To be precise, it strips from each line a number of spaces equal to the minimal indentation of the string as a whole (disregarding the indentation of empty lines) **Steps To Reproduce** In a nix file, include something like this and indent _with tabs_: ```nix home.file."myfile".text = '' # This should not be indented in the generated file. ''; ``` This results in the generation of myfile as follows, _with_ unwanted indentation, _with_ an unwanted empty line, and _with_ trailing space on the empty line: ``` > > # This should not be indented in the generated file. > ``` (where `>` represents a tab character) **Expected behavior** "myfile" contains the text (without indentation and without additional empty line): ``` # This should not be indented in the generated file. ``` **`nix-env --version` output** nix-env (Nix) 2.13.5 **Additional context** I did come across https://github.com/NixOS/nix/issues/3759, but it was closed without an understandable reason, other than: > We can't change this because it would be incompatible (it could cause the result of evaluating a derivation to change). _(The author of that comment is [against the use of tabs in general](https://github.com/NixOS/nix/pull/2911#issuecomment-498141657).)_ Supporting tabs (and different newline formats) is an absolutely basic aspect of programming languages. Nix should not require any special handling/attention when working with tabs. **Priorities** Add :+1: to [issues you find important](https://github.com/NixOS/nix/issues?q=is%3Aissue+is%3Aopen+sort%3Areactions-%2B1-desc).

github.com/NixOS/nix

Allow tab usage in indented strings

master ← cslamber:master

opened 03:06AM - 03 Jun 19 UTC

cslamber

+25 -8

There are a fair number of derivations in nixpkgs that seem to unintentionally u…se tabs in their expressions instead of spaces (evilwm, gitit, animbar, ocaml-expat), and right now spaces are the only indentation recognized. This change allows tabs to be used by having whatever whitespace character appears first at the start of lines as the character used for indentation. No assumptions need to be made about tab configuration because this does not support mixed tabs and spaces. This would also allow people who prefer tabs in their local derivations to use that instead. The only place where mixing is acceptable is with the final ignored line, as some of the packages specified above have spaces indenting their final lines, which seem to be intended to be ignored. This is my first PR, so feel free to modify or critique it however you want.

github.com/NixOS/nix

feat: tab support for indentation stripping

master ← magistau:master

opened 05:33PM - 08 Feb 24 UTC

magistau

+48 -22

# Motivation Many users prefer using hard tabs for indentation, but the exist…ing indentation stripping logic only considers spaces as indentation characters and therefore doesn't strip any tab characters. # Context Closes #7834. Previously, `stripIndentation` would look for the longest common space-consisting line prefix; now it finds either the longest common space-consisting or tab-consisting prefix. A tab after a space is not considered as indentation, neither is a space after a tab.