teto
March 15, 2020, 4:29pm
1
I am looking for a solution for luarocks to deal with cmake based packages. The best fix would be to have structured cmakeFlags which was mentioned in [RFC 0013] Ergonomic `cmakeFlags` by aneeshusa · Pull Request #13 · NixOS/rfcs · GitHub , with PRs like [WIP/RFC] Make `cmakeFlags` more ergonomic by aneeshusa · Pull Request #17886 · NixOS/nixpkgs · GitHub .
Seems like stdenv: enable __structuredAttrs by globin · Pull Request #72074 · NixOS/nixpkgs · GitHub is the way forward.__structuredAttrs = true for just my derivation but it ended up with /setup: No such file or directory errors.
Cheers
3 Likes
teto
April 3, 2020, 1:02pm
3
I dont mind helping with the workload as it is a crucial feature that could really help clean nixpkgs. But I would need some guidance and I guess it might not be easy to split the load anyway.
In case anyone is interested, I opened a (draft) PR tackling this.
NixOS:staging ← ShamrockLee:cmake-structured-attrs
opened 01:25AM - 28 Mar 24 UTC
## Description of changes
### Summary
Provide structural attributes suppor… t to the setup hooks of CMake, lint them with ShelllCheck, and add package tests to `cmake` to ensure that these hooks always passe ShellCheck.
Fix #289037.
### New interface
Provide interface to structurally specify CMake `-D` flags, i.e. `cmakeDFlagAttrs` and `cmakeDFlagEvalAttrs`. Not only can it be specified by phases/hooks run before `cmakeConfigurePhase`, but also as Nix Language attributes when `__structuralAttrs = true`.
### Questions
- Naming.
- Any suggestions to the new names `cmakeDFlagAttrs` and `cmakeDFlagEvalAttrs`?
- Boolean and non-string type management.
- Should we allow boolean and other non-string type when `cmakeDFlagAttrs` is used inside the Nix Language expression? That would be quite convenient in Nix expression level, but require an extra layer of conversion. This PR currently doesn't provide such support.
<!--
For package updates please link to a changelog or describe changes, this helps your fellow maintainers discover breaking updates.
For new packages please briefly describe the package or provide a link to its homepage.
-->
## Things done
- Built on platform(s)
- [ ] x86_64-linux
- [ ] aarch64-linux
- [ ] x86_64-darwin
- [ ] aarch64-darwin
- For non-Linux: Is sandboxing enabled in `nix.conf`? (See [Nix manual](https://nixos.org/manual/nix/stable/command-ref/conf-file.html))
- [ ] `sandbox = relaxed`
- [ ] `sandbox = true`
- [ ] Tested, as applicable:
- [NixOS test(s)](https://nixos.org/manual/nixos/unstable/index.html#sec-nixos-tests) (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
- and/or [package tests](https://nixos.org/manual/nixpkgs/unstable/#sec-package-tests)
- or, for functions and "core" functionality, tests in [lib/tests](https://github.com/NixOS/nixpkgs/blob/master/lib/tests) or [pkgs/test](https://github.com/NixOS/nixpkgs/blob/master/pkgs/test)
- made sure NixOS tests are [linked](https://nixos.org/manual/nixpkgs/unstable/#ssec-nixos-tests-linking) to the relevant packages
- [ ] Tested compilation of all packages that depend on this change using `nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"`. Note: all changes have to be committed, also see [nixpkgs-review usage](https://github.com/Mic92/nixpkgs-review#usage)
- [ ] Tested basic functionality of all binary files (usually in `./result/bin/`)
- [24.05 Release Notes](https://github.com/NixOS/nixpkgs/blob/master/nixos/doc/manual/release-notes/rl-2405.section.md) (or backporting [23.05](https://github.com/NixOS/nixpkgs/blob/master/nixos/doc/manual/release-notes/rl-2305.section.md) and [23.11](https://github.com/NixOS/nixpkgs/blob/master/nixos/doc/manual/release-notes/rl-2311.section.md) Release notes)
- [ ] (Package updates) Added a release notes entry if the change is major or breaking
- [ ] (Module updates) Added a release notes entry if the change is significant
- [ ] (Module addition) Added a release notes entry if adding a new NixOS module
- [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md).
<!--
To help with the large amounts of pull requests, we would appreciate your
reviews of other pull requests, especially simple package updates. Just leave a
comment describing what you have tested in the relevant package/service.
Reviewing helps to reduce the average time-to-merge for everyone.
Thanks a lot if you do!
List of open PRs: https://github.com/NixOS/nixpkgs/pulls
Reviewing guidelines: https://github.com/NixOS/nixpkgs/blob/master/pkgs/README.md#reviewing-contributions
-->
---
Add a :+1: [reaction] to [pull requests you find important].
[reaction]: https://github.blog/2016-03-10-add-reactions-to-pull-requests-issues-and-comments/
[pull requests you find important]: https://github.com/NixOS/nixpkgs/pulls?q=is%3Aopen+sort%3Areactions-%2B1-desc
2 Likes