Weekly leaderboards

There hasn’t been much incentive for approvals until now: committers could just merge immediately, non-committers would get frustrated because their review doesn’t have any effect. Maybe PRs already reviewed will change that. You can already see that in @tomberek’s efforts for example :slight_smile:

I have thought about counting a merge of a PR that doesn’t have an approval by anybody else as an approval. Some committers use the approval feature before merging, others don’t so I think that would be a fairer question.

That would currently drown out non-committer approvals a bit, but maybe that will change. If people start using the distinction between “reviewer” and “merger” more, just listing the merges for committers doesn’t seem fair either.

Here are some more stats, with new PRs included and merge-without-approval counted as approval. Cutoff at 3 this time, to save space and since it is more unique than 10.

Approvals

  1. xeji (100)
  2. matthiasbeyer (63)
  3. timokau (31)
  4. tomberek (25)
  5. worldofpeace (21)

Requests for changes

  1. timokau (17)
  2. aanderse (11)
  3. worldofpeace (7)
  4. xeji (7)
  5. matthiasbeyer (6)

Merges

  1. xeji (112)
  2. timokau (32)
  3. ryantm (22)
  4. worldofpeace (22)
  5. markuskowa (17)

New PRs

  1. dtzWill (21)
  2. matthewbauer (8)
  3. aanderse (7)
  4. romildo (7)
  5. vdemeester (7)

And here is the script I used in case someone wants to tinker. Be warned: its neither pretty nor commentated, but also not very complicated.