# Weekly leaderboards

**URL:** https://discourse.nixos.org/t/weekly-leaderboards/2637
**Category:** Uncategorized
**Created:** [April 9, 2019, 10:12pm UTC](https://discourse.nixos.org/t/weekly-leaderboards/2637 "2019-04-09T22:12:13Z")
**Posts on this page:** 1
**Showing post:** 9

<div class="post-metadata">

### Author: ![timokau](https://discourse.nixos.org/user_avatar/discourse.nixos.org/timokau/32/40_2.png) [@timokau](https://discourse.nixos.org/u/timokau)
#### Post date: [April 10, 2019, 10:42am UTC](https://discourse.nixos.org/t/weekly-leaderboards/2637/9 "2019-04-10T10:42:55Z")

</div>

> [@7c6f434c](#):
>
> > ### Approvals
> 
> If I sleepwalk into top-11 the week when I was at a conference, maybe this is not such a good metric!

There hasn’t been much incentive for approvals until now: committers could just merge immediately, non-committers would get frustrated because their review doesn’t have any effect. Maybe [PRs already reviewed](https://discourse.nixos.org/t/prs-already-reviewed/2617) will change that. You can already see that in @tomberek’s efforts for example 🙂

> [@7c6f434c](#):
>
> Maybe a separate top for non-committer approvals, as the non-merge reviews by committers are often a separate story?

I have thought about counting a merge of a PR that doesn’t have an approval by anybody else as an approval. Some committers use the approval feature before merging, others don’t so I think that would be a fairer question.

That would currently drown out non-committer approvals a bit, but maybe that will change. If people start using the distinction between “reviewer” and “merger” more, just listing the merges for committers doesn’t seem fair either.

Here are some more stats, with new PRs included and merge-without-approval counted as approval. Cutoff at 3 this time, to save space and since it is more unique than 10.

### Approvals

1. xeji (100)
2. matthiasbeyer (63)
3. timokau (31)
4. tomberek (25)
5. worldofpeace (21)

### Requests for changes

1. timokau (17)
2. aanderse (11)
3. worldofpeace (7)
4. xeji (7)
5. matthiasbeyer (6)

### Merges

1. xeji (112)
2. timokau (32)
3. ryantm (22)
4. worldofpeace (22)
5. markuskowa (17)

### New PRs

1. dtzWill (21)
2. matthewbauer (8)
3. aanderse (7)
4. romildo (7)
5. vdemeester (7)

And [here](https://github.com/timokau/nixpkgs-stats/blob/39ad30aed0f198633e1b8febfe707a27368d8685/stats.py) is the script I used in case someone wants to tinker. Be warned: its neither pretty nor commentated, but also not very complicated.

---

_[View the full topic](https://discourse.nixos.org/t/weekly-leaderboards/2637)._