Who can merge nixpkgs PR?

1

Hi all,

There’s a pending PR to update ble.sh version: blesh: 0.3.4 -> 0.4.0-devel3 by r-ryantm · Pull Request #226852 · NixOS/nixpkgs · GitHub

The maintainer of the package doesn’t have the rights to merge the PR :thinking: , so who can do it then?

Thank you.

2

There is a “PRs in distress” gigathread when people ask for review and we committers can look and merge.

Anyone is free to test, suggest changes and approve any PRs. However, only committers can merge them.

2 Likes
3

those people can Sign in to GitHub · GitHub

Please don’t ping them all with an @

1 Like
4

Thanks Sandro. Your GitHub link shows 404. Is it a private repo?

5

It is not a repository, it is a list of team members, and it seems as if that list isn’t publicly visible.

In my opinion it isn’t nice to ping the team or individuals from the team for a merge anyway.

If you have something that has been reviewed, you can wait for a merge or ask in the nixpkgs matrix channel, or in the inofficial discord or here in the review/ready2merge/distress threads.

1 Like
6

You need to be a member of the NixOS Github org to see it

7

Thanks for elaborating!
I have now bookmarked the distress thread and will use it when in distress :slight_smile:

4 Likes