payas
March 15, 2022, 2:02pm
1
From what I see, Yuzu itself is FLOSS (nixpkgs/base.nix at 73ad5f9e147c0d2a2061f1d4bd91e05078dc0b58 · NixOS/nixpkgs · GitHub ) and the Nintendo proprietary stuff is not shipped with it.
The licenses are also compliant, so I’m wondering why it is not built and cached by upstream cache.nixos.org .
hexa
March 15, 2022, 2:30pm
2
CC-BY-ND-3.0 is a non-free license since it does not allow derivative works.
1 Like
Atemu
March 15, 2022, 4:39pm
3
Note that CC-BY-ND-3.0 only applies to some of the icons used in the app. I’d honestly open an upstream issue on that.
Another possibility is to build all of the code in one derivation and then have a second derivation that adds the icons. The former would be Free, so hydra could build it. The latter is unfree but since it only adds a few icons, it could be built on the user’s macine in under a second.
1 Like
payas
March 15, 2022, 5:27pm
4
Yes please. My machine is not too bad really, but Yuzu is heavy and needs a while to build. This solution sounds like best of both worlds. I will try to take on this task, but my Nix knowledge is limited enough that it will take me a while and if somebody wants to have a go I wouldn’t mind. Will even be a good example for me.
Atemu
March 15, 2022, 5:42pm
5
That sounds like a good task to get into Nix. Though I’d urge you to ask about this issue upstream first.
Using unfree assets is an issue and I don’t even want to know how the GPL plays into that. The icons aren’t really an essential component and could easily be substituted with any other that looks vaguely similar.
1 Like
j-k
March 17, 2022, 11:52am
6
I’m confused how CC BY-ND 3.0
causes issues here. The images are used as-is and not “remixed, transformed, or built upon”
However I’d also add I’m not sure icons8 icons are actually CC BY-ND 3.0
https://intercom.help/icons8-7fb7577e8170/en/articles/5534926-universal-multimedia-licensing-agreement-for-icons8
depending on how scary the license is for the free yuzu bit you might need to remove the icons from your src download
NixOS:master
← 06kellyjac:p7zip
opened 08:18PM - 14 Mar 22 UTC
###### Description of changes
<!--
For package updates please link to a chan… gelog or describe changes, this helps your fellow maintainers discover breaking updates.
For new packages please briefly describe the package or provide a link to its homepage.
-->
- p7zip: clarify license and remove unRAR code from src drv
- ~p7zip: add notice of the license updates~
In the same vein as #163999 and inspired by #163680 this tackles unRAR code
p7zip was already correctly building without unRAR code by default but since the
unRAR licensing also refers to the code being on your hard drive it's best to nuke
it from the src drv like in #163999 (and most of the changes were reusable from there)
cc: @7c6f434c
###### Things done
- Built on platform(s)
- [X] x86_64-linux
- [ ] aarch64-linux
- [ ] x86_64-darwin
- [ ] aarch64-darwin
- [X] For non-Linux: Is `sandbox = true` set in `nix.conf`? (See [Nix manual](https://nixos.org/manual/nix/stable/command-ref/conf-file.html))
- [X] Tested, as applicable:
- [NixOS test(s)](https://nixos.org/manual/nixos/unstable/index.html#sec-nixos-tests) (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
- and/or [package tests](https://nixos.org/manual/nixpkgs/unstable/#sec-package-tests)
- or, for functions and "core" functionality, tests in [lib/tests](https://github.com/NixOS/nixpkgs/blob/master/lib/tests) or [pkgs/test](https://github.com/NixOS/nixpkgs/blob/master/pkgs/test)
- made sure NixOS tests are [linked](https://nixos.org/manual/nixpkgs/unstable/#ssec-nixos-tests-linking) to the relevant packages
- [X] Tested compilation of all packages that depend on this change using `nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"`. Note: all changes have to be committed, also see [nixpkgs-review usage](https://github.com/Mic92/nixpkgs-review#usage)
- [X] Tested basic functionality of all binary files (usually in `./result/bin/`)
- [22.05 Release Notes (or backporting 21.11 Release notes)](https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md#generating-2205-release-notes)
- [ ] (Package updates) Added a release notes entry if the change is major or breaking
- [ ] (Module updates) Added a release notes entry if the change is significant
- [ ] (Module addition) Added a release notes entry if adding a new NixOS module
- [ ] (Release notes changes) Ran `nixos/doc/manual/md-to-db.sh` to update generated release notes
- [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md).
<!--
To help with the large amounts of pull requests, we would appreciate your
reviews of other pull requests, especially simple package updates. Just leave a
comment describing what you have tested in the relevant package/service.
Reviewing helps to reduce the average time-to-merge for everyone.
Thanks a lot if you do!
List of open PRs: https://github.com/NixOS/nixpkgs/pulls
Reviewing guidelines: https://nixos.org/manual/nixpkgs/unstable/#chap-reviewing-contributions
-->
another option is to join ryujinx gang
Atemu
March 24, 2022, 10:42am
7
Not allowing derivative works means the license is non-free and hydra won’t touch it.
The derivation seems to have gotten their info from here: yuzu/license.txt at c50f2bd4f6797b778ae21dfed341129ed4a2252c · yuzu-emu/yuzu · GitHub
But, looking at that license, it’s definitely not CC BY-ND but a custom non-free license. I have found hints that icons8 were CC BY-ND at some point though?
I think an upstream issue is more than necessary at this point.
j-k
March 28, 2022, 8:24am
8
I opened an issue the other day about the license not being great and that the old license might not even apply anymore
opened 11:03AM - 24 Mar 22 UTC
Are the icons8 icons actually CC BY-ND 3.0?
https://github.com/yuzu-emu/yuzu/… blob/master/license.txt#L344-L361
This license below doesn't look CC BY-ND 3.0, did they used to be licensed that way?
https://intercom.help/icons8-7fb7577e8170/en/articles/5534926-universal-multimedia-licensing-agreement-for-icons8
---
When packaging yuzu for nixpkgs we dont distribute a cached build since it uses CC BY-ND 3.0 icons let alone whatever that custom unfree license is.
Unrelated to this discussion they’ve swapped to GPLv3 to use some Apache 2.0 code and all the icon licensing is gone from the bottom of the license
The icons are still there though
2 Likes
payas
March 28, 2022, 9:29am
9
All the icons are still there but the place to look for their licenses is different now: yuzu/license.md at 7382e7a5c811ec8ed4270818dcfe8bba357973b2 · yuzu-emu/yuzu · GitHub
Someone recently created a pull request for yuzu replacing the non-free icons with ones under Apache 2.0, MIT and CC0.
I applied this patch in nixpkgs , so now there is nothing in the way of cached binaries once it hits the channels
6 Likes
payas
May 13, 2022, 3:39pm
11
Thanks a lot for following up and fixing!
1 Like
payas
August 15, 2022, 6:15am
12
Looks like PR is merged. The patch can be removed now.