There’s a couple of issues with that systemd service though (its type should be oneshot, and in general I think its functionality could be achieved with kernel command line options and systemd-tmpfiles).
For the kernel config changes, do any other distros enable these settings by default? If so, you could make a case for enabling them also for the nixos kernel builds. I’d do that as a separate PR.