Agenda
- Triage (30 min)
- Check stuck backport PRs
- Enabling contributors; permissions (15-30 min)
- Discussion (< 15 min)
Triage
-
Fix user namespace detection with old kernels by rodarima · Pull Request #7234 · NixOS/nix · GitHub
- assigned to @edolstra
-
Evaluate nix-shell -i args relative to script by matthewbauer · Pull Request #5088 · NixOS/nix · GitHub
- assigned to @tomberek
-
Make 'logger' a std::unique_ptr by edolstra · Pull Request #6962 · NixOS/nix · GitHub
- postponed
-
Guard uses of lutimes, for portability by puffnfresh · Pull Request #7048 · NixOS/nix · GitHub
- assigned to @Ericson2314 to fix the
autoconf
checks
- assigned to @Ericson2314 to fix the
-
Make multi-user installer idempotent by iFreilicht · Pull Request #7603 · NixOS/nix · GitHub
- @regnat: will bring it up in the installer work group
-
builtins.substring: fix int overflow by yorickvP · Pull Request #7222 · NixOS/nix · GitHub
- assigned to @regnat
- will ping @fricklerhandwerk to discuss error message
- assigned to @regnat
-
macOS updates often break nix installation (updates replace path-hooks on multi-user install) · Issue #3616 · NixOS/nix · GitHub
- to discuss
-
Preserve TMPDIR on macOS in 'nix shell' by bouk · Pull Request #7492 · NixOS/nix · GitHub
- assigned to @regnat
-
nix develop: use proper permissions for $TMPDIR by winterqt · Pull Request #6974 · NixOS/nix · GitHub
- couldn’t determine which problem it solves exactly
- postponed, waiting for author to provide a reproducer
-
Search improvements for --file and --expr by dramforever · Pull Request #7668 · NixOS/nix · GitHub
- idea approved, to discuss implementation
- @Ericson2314 and @tomberek will report back with a proposal
- postponed
Backport PRs
- @fricklerhandwerk: search query for backports
-
@edolstra: nothing happened because no one merged them
- generally we probably only want to maintain the previous stable release, i.e. the one used in the current Nixpkgs/NixOS release
- 2.9 is pretty old at this point
- we can create a new release if there is demand though
- generally we probably only want to maintain the previous stable release, i.e. the one used in the current Nixpkgs/NixOS release
- @Ericson2314: related Test against stable versions by Ericson2314 · Pull Request #5572 · NixOS/nix · GitHub
- [Backport 2.11-maintenance] RunPager: Stop the progress bar by github-actions[bot] · Pull Request #7033 · NixOS/nix · GitHub
-
@Ericson2314: let’s focus on the version relevant for Nixpkgs (2.11)
- agreement: merge the backports to 2.11 and close the other ones
-
@fricklerhandwerk: what about the 2.3 backports
-
@Ericson2314: will make a case some other time
- will put it on the board when ready
-
@Ericson2314: will make a case some other time
-
@regnat: is there a reason that backport PRs get stuck by default?
- @fricklerhandwerk: it’s because the PRs are made by GH actions, and they don’t allow recursive actions
-
@Ericson2314: will open an issue to deal with it
- @fricklerhandwerk: not sure what to do about it in principle
- @edolstra: worst case write a bot that closes and re-opens them
- @regnat: we can’t be the only ones with the issue, just have to investigate
-
@roberth had opened Remove push protection from backport branches · Issue #7832 · NixOS/nix · GitHub
- related but not the exact same
Contributors and permissions
-
@fricklerhandwerk granted @Ericson2314 write access to the board
- too much hassle managing requests that he forwards from contributors
- consider adding more people who can triage and curate the board
- @regnat: all for giving people more access, e.g. @abathur who’s the only one working on the installer
-
@tomberek: we also have to discuss adding @Ericson2314 to the team
- add @Ericson2314 to the Nix team by fricklerhandwerk · Pull Request #7580 · NixOS/nix · GitHub
- agreement: make a decision next time we have all members
Discussion
-
@Ericson2314: would like to bring up doing more work async between the meetings
- propose to only bring up bigger issues in the whole group
- e.g. 2+ team members review async and merge without guilt
- Single reviewer is still fine
- Have been instances of people approving but not feeling comfortable hitting the button – that’s not their fault!
- “two people rule” is about getting over the hurdle without needing a synchronous meeting
- with multiple people in effect jointly hitting “merge” together, no single person can be unfairly scape-goated
- What would make people more comfortable reviewing more code?
-
@fricklerhandwerk: alternative, what we did so far, is dumping almost everything on the triage board and dispatch from there
- @regnat: yes, especially for things that are uncontroversial it’s productive
- @Ericson2314: we have lots of things in the backlog, and while we get through with new things, the backlog doesn’t really shrink
- @fricklerhandwerk: if we focused more on making long-overdue design decisions, new PRs will more likely fall into place naturally, because people will find it easier to determine what to do
- agreement: @Ericson2314 will make a write-up with proposal
- @fricklerhandwerk: ideally direct PR to team handbook!
-
Generate API docs with Doxygen by Ericson2314 · Pull Request #7896 · NixOS/nix · GitHub
- decision: we really want this
- add a separate makefile target and derivation output to avoid the impression this is a public interface
- decision: we really want this