Attendees: @edolstra @robert @L-as @Ericson2314 @tomberek
nix: 2.18 -> 2.24 by roberth · Pull Request #335342 · NixOS/nixpkgs · GitHub
A performance regression was noted.
It’s unclear what’s the cause of this, and the team has not been able to reproduce it yet.
@roberth opened libgit2, GitRepo: Write thin packfiles by roberth · Pull Request #11330 · NixOS/nix · GitHub, which might speed up the tarball cache by reducing the amount of (small) I/O operations required. Copying to the store is not optimized by that, but if we see a, say, 20% or higher speedup, this would suggest that I/O ops/s is the bottleneck in these cases.
No make unittests by Ericson2314 · Pull Request #11301 · NixOS/nix · GitHub
The commit that removes make check was merged too soon, as the manual is not up to date.
Partial revert: Revert "Remove unit tests from old build system" (too soon) by roberth · Pull Request #11331 · NixOS/nix · GitHub
Requirements for the switch and removal of any make targets:
- make sure
devShellconfigurePhaseetc run Meson - make sure the entire local dev workflow is ok
- make sure the manual is updated to use meson exclusively
- link to 2.24 manual for latest make-based workflow, which is relevant for backports
fix: check to see if there are any lines before by tomberek · Pull Request #11329 · NixOS/nix · GitHub
Merged.
doc: Manage expectations for eval-cache by roberth · Pull Request #11322 · NixOS/nix · GitHub
Reviewed by @tomberek, improved
nix-daemon.sh profile script: operate under `set -u` in bash by mjgallag · Pull Request #11308 · NixOS/nix · GitHub
Looks good. Helping out with the test. Approved.
fix: bash mangles flake ref completion by 0x5a4 · Pull Request #11240 · NixOS/nix · GitHub
Approved, @tomberek opens issue for alternate solution.
feat: better warning for common SSL error by tomberek · Pull Request #11246 · NixOS/nix · GitHub
Approved. Merging…
libutil: rename and optimize closeMostFDs by Mic92 · Pull Request #11278 · NixOS/nix · GitHub
Approved. Merging…
parser-state: fix attribute merging by rhendric · Pull Request #11294 · NixOS/nix · GitHub
Idea approved. Requires more carefull review. Assigned.
Make $HOME=/proc/homeless-shelter instead of /homeless-shelter by noamraph · Pull Request #11300 · NixOS/nix · GitHub
Idea approved for Linux. Darwin has strict controls on its root, so shouldn’t have this problem