Wednesday triaging session
Attendees: bryanhonof @edolstra @tomberek @roberth @ericson2314
Triaging
Add an owner check when searching for the flake root by thufschmitt · Pull Request #6464 · NixOS/nix · GitHub
Do we want this? We’ve had the opposite issue reported, where our call to git (or was it libgit2) was causing this to happen.
- Some of these checks are excessive, but this one seems ok (just not traversing up; not rejecting outright)
Make multi-user installer idempotent by iFreilicht · Pull Request #7603 · NixOS/nix · GitHub
This is something we would like. We need to reach out and make sure the installer working group knows we’re ok with such changes.
@tomberek will reach out
Allow `diff-closures` to output `json` by Pamplemousse · Pull Request #7243 · NixOS/nix · GitHub
Assigned to @edolstra
nix develop: parse multi-line vars in get-env.sh by impl · Pull Request #6718 · NixOS/nix · GitHub
@roberth would like to move all of this into Nixpkgs where it belongs, but we could merge a fix.
s3-binary-cache-store: getFile streaming from S3 by mupdt · Pull Request #6824 · NixOS/nix · GitHub
Abandoned PR, but a good idea. Can be picked up by a contributor.
Redirect some Nix commands output to a pager by thufschmitt · Pull Request #4972 · NixOS/nix · GitHub
Idea approved.
Review
Document common options in stable nix binaries by tfc · Pull Request #11663 · NixOS/nix · GitHub
Reviewed.
Add `shortName` for `quiet` flag by shivaraj-bh · Pull Request #11652 · NixOS/nix · GitHub
Closed
nix behind SSL proxy by zoranbosnjak · Pull Request #11638 · NixOS/nix · GitHub
To close
We see in the comments you’ve been having trouble fixing this in other ways, but we really cannot afford to add misc per-program environment variable hacks to the official nix sandbox.
This should be possible to implement via a script which checks e.g. which paths are accessible, which env variables are set, etc., to avoiding need to explicitly check whether we are sandboxing.
doc/manual: Add 'Debugging Nix' section by michaelvanstraten · Pull Request #11637 · NixOS/nix · GitHub
Seems good, assigned to @fricklerhandwerk
Introduce `nix derivation instantiate` by layus · Pull Request #11506 · NixOS/nix · GitHub
This clashes with RFC 92 a bit, because it is unclear what it should do in the case of derivations that are themselves the build outputs of derivations.
We don’t want to do this now in light of those uncertainties, and would much prefer it if you could work on the plan outlined in `--derivation` considered harmful, remove it in lieu of `^` and new stuff · Issue #7261 · NixOS/nix · GitHub
We would also appreciate advice on how to make issues like this more prominant so contributors like you don’t end up spending a bunch of time implementing something that overlaps with an agreed-upon plan that’s just waiting to be implemented.
Sorry for the confusing discussion on this, and delayed rejection.
Add flag `set-env-var` to `MixEnvironment`, and rename old ones by bryanhonof · Pull Request #11494 · NixOS/nix · GitHub
Assigned @roberth