Wednesday triage session
Attendees: @edolstra @roberth @xokdvium @Ericson2314 @tomberek @Mic92 @fzakaria
Agenda
- Monday meeting time change?
- Can’t decide a single time slot. We’ll set up two: current time + extra evening time meeting
- New extra Monday meeting: 16:00 UTC!
- Calendar update forthcoming…
- Network namespace progress update
- @tomberek has looked at pasta usage, but not a network bridge
- @Mic92: do we need to isolate each build or is the whole daemon ok?
- @tomberek: could be good starting point, but there’s still a concern of cooperating derivations instead of derivation ↔ outside cooperation.
- @Mic92: seems less pressing
- @tomberek: per
nixbld
user is also an option
Triage
Build failure reason is not propagated correctly in `ssh:` remote build · Issue #13465 · NixOS/nix · GitHub
Triaged in meeting:
- Possibly duplicate
- @Ericson2314 big fan of removing the build hook (casual readers: not the post build hook)
- Removing the build hook is not entirely trivial because timeouts need to be implemented differently.
- See Discussion
- C++ refactor can be distinct from protocol changes. Async cancellation on
ssh:
is possible by making theStore
a connection pool, and shutting down a connection to perform the kill.
@Ericson2314, @edolstra, @xokdvium are interested on pairing on build hook C++ refactor
Add a test case where fetchGit is failing to cache due to packed-refs by fzakaria · Pull Request #13456 · NixOS/nix · GitHub
Reviewed
Unpeel reference for git+file by fzakaria · Pull Request #13521 · NixOS/nix · GitHub
Merged
Discussion
Remove the build hook mechanism · Issue #1221 · NixOS/nix · GitHub
- Removing the build hook
- Might need refactor using coroutines
- @xokdvium: Lix have done some work in this direction
- @Ericson2314: Multiple protocol replacements are in development, not just Lix but also the STA Hydra improvements (gRPC)
- @Ericson2314: Would like to get rid of
ssh:
- @edolstra: May want an asynchronous interface (initiating separately from waiting and such)
Rip off the bandaid: Format the codebase with clang-format by grahamc · Pull Request #13108 · NixOS/nix · GitHub
- We merged the codebase reformatting earlier
- @Mic92: rebase script also works