Monday hacking session
Usually not the best notes, because we’re already hacking and multitasking, but that won’t stop us from posting what we did write down.
You’re always welcome to join our meetings!
Attendees: @edolstra @roberth @Mic92 @lovesegfault @xokdvium @Ericson2314
[DEMO] S3 Transfer Acceleration by lovesegfault · Pull Request #13791 · NixOS/nix · GitHub
I think this should be moved to
s3.cc/s3.hh.There can be a similar pattern as
FileTransferwhere we have agetS3CredentialProviderCacheandmakeS3CredentialProviderCache.makeFileTransferwould take anconst S3CredentialProviderCache &reference.getFileTransferwould callgetS3CredentialProviderCacheto get the reference, andDerivationBuilder(for builtins fetching) would have a little#if NIX_WITH_S3_SUPPORTto callmakeS3CredentialProviderCacheto make a fresh one for the forked case.The question in my mind then is how does the underlying
aws-crt-cppcope with forking? I see theseGetOrCreateStaticDefaultClientBootstrapand similar functions are also working with global mutexes, that would probably pose a similar problem.What do you think @xokdvium?
SQLite: fsync db.sqlite-shm before opening the database by xokdvium · Pull Request #13826 · NixOS/nix · GitHub
Opened, approved