buildFHSEnv overriding

Development Nixpkgs Architecture
1

I noticed that there currently seems to be no way to override inputs to buildFHSEnv as it isn’t wrapped with lib.makeOverrideable and overrideAttrs is also not functional to pass a modified targetPkgs for example.

Is there a architectural reason overriding was not considered or was it just forgotten?

4 Likes
2

No and it’s in dire need of a refactor anyways. Feel free to hack on it if you’re motivated.

As long as the external API for callers of the builder remains in-tact (or has reasonable changes) I don’t think anyone would disapprove.

1 Like
3

for now i wrapped it in lib.makeOverridable, but as pointed out it should be refactored. When are the bulidFHSuserEnv aliases supposed to get deprecated btw? I think it should be safe to add a deprecation warning as they are no longer used in nixpkgs.

1 Like
4

Deprecations should last until at least the next release, after which it could be removed.

5

Can you please elaborate?

6

I’m not sure what’s you want me to elaborate on here; someone needs to have a good look at the code and organise it better.