Disabling fzf fish integration doesn't work

dpc · March 12, 2023, 6:10am

I want to disable sourcing fish scripts bundled with fzf (so I can use fzf.fish plugin exclusively). It seems like this should be possible with:

  programs.fish = {
    enable = true;
    # fzf conflicts with fish.fzf plugin so we don't load configs provided by other packages...
    vendor.functions.enable = false;
    vendor.config.enable = false;
    # ... and load the ones we like manually
    # check `ls -alh /run/current-system/sw/share/fish/vendor_conf.d` for a full list
    shellInit = ''
      source ${pkgs.direnv}/share/fish/vendor_conf.d/direnv.fish
      source ${pkgs.fishPlugins.fzf-fish}/share/fish/vendor_conf.d/fzf.fish
    '';
  };

My understanding is setting these to false will make this:

github.com

NixOS/nixpkgs/blob/5eb98948b66de29f899c7fe27ae112a47964baf8/nixos/modules/programs/fish.nix#L287

    
      
            in
              pkgs.buildEnv {
                name = "system_fish-completions";
                ignoreCollisions = true;
                paths = map generateCompletions config.environment.systemPackages;
              };
          }
          
          
# include programs that bring their own completions
          {
            pathsToLink = []
            ++ optional cfg.vendor.config.enable "/share/fish/vendor_conf.d"
            ++ optional cfg.vendor.completions.enable "/share/fish/vendor_completions.d"
            ++ optional cfg.vendor.functions.enable "/share/fish/vendor_functions.d";
          }
          
          
{ systemPackages = [ pkgs.fish ]; }
          
          
{
            shells = [
              "/run/current-system/sw/bin/fish"

not link these config to profile.

However it doesn’t seem to work:

> ls /run/current-system/sw/share/fish/vendor_conf.d
direnv.fish  fzf.fish  load-fzf-key-bindings.fish

Am I misunderstanding something? Any ideas why is not working?

tshakah · March 31, 2023, 2:53pm

I’m getting the same behaviour. Ideally enabling fishPlugins.fzf-fish would disable the built-in fzf one.

Babalas · June 2, 2023, 3:08am

Did you have any luck working around this issue? Seems programs.fzf.enableFishIntegration = false; doesn’t stop it either

dpc · June 2, 2023, 3:25am

Nope. Gave up, wasn’t that important to me.

pxc · June 2, 2023, 6:31am

I’m interested in fixing this, so I’m posting here to remind myself to come back to it.

Note that normally (outside of a Nix context), you’d disable a vendor-supplied config snippet by preempting it in Fish’s config sourcing path with a file of the same name. So to completely disable vendor_conf.d/fzf.fish, you’d just create an empty file at ~/.config/fish/conf.d/fzf.fish. So the presence of the vendor-supplied config file in your Nix profile doesn’t necessarily mean that the integration is enabled.

Babalas · June 5, 2023, 7:57am

I was checking using the 3 bindings fzf enables. Worked around it by unbinding, then rebinding to the fishPlugin functions but the empty file could be an option.